Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com
 designates 209.85.214.47 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <87wqiz7728.fsf@v35516.1blu.de>
References: <20131220171807.E722D23888FE@eris.apache.org>
	<52B47CB3.30202@apache.org>
	<CACZkXPxR6559Lur3zcM2kg0GT17RLX-XFYUz79UrA7ZC54smrw@mail.gmail.com>
	<87wqiz7728.fsf@v35516.1blu.de>
Date: Fri, 20 Dec 2013 13:07:11 -0500
Message-ID: 
 <CACZkXPyphKOUpE4uZn=wBV8pH8oA+3OfrQjO_nS-mWbiTtngOw@mail.gmail.com>
Subject: Re: svn commit: r1552745 -
 /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java
From: Gary Gregory <garydgregory@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=f46d0420a903b598b104edfb25f7

--f46d0420a903b598b104edfb25f7
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Fri, Dec 20, 2013 at 12:42 PM, Stefan Bodewig <bodewig@apache.org> wrote=
:

> On 2013-12-20, Gary Gregory wrote:
>
> > On Fri, Dec 20, 2013 at 12:21 PM, Emmanuel Bourg <ebourg@apache.org>
> wrote:
>
> >> Le 20/12/2013 18:18, ggregory@apache.org a =C3=A9crit :
>
> >>> Remove some unnecessary parentheses.
>
> >> I'd argue they make the code easier to read. Reading bit shifting code
> >> is quite painful, some parentheses help greatly.
>
>
> > That's why it's only "some" and not "all" unnecessary parentheses.
>
> > IMO:
>
> >    tableSize =3D (1 << 8);
>
> agree in this case, but not with
>
> -            value |=3D (nextByte << (8 * i));
> +            value |=3D nextByte << 8 * i;
>
> <
> http://svn.apache.org/viewvc/commons/proper/compress/trunk/src/main/java/=
org/apache/commons/compress/archivers/sevenz/SevenZFile.java?r1=3D1552740&r=
2=3D1552739&pathrev=3D1552740
> >
>
> at least I need to think about it to be really sure * has precedence
> over <<
>

I've made some adjustments to this file in SVN. My intention was to not
change the bit twiddling expressions, my mistake. Now we have:

            value |=3D nextByte << (8 * i);

Gary

>
> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


--=20
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/baue=
r3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--f46d0420a903b598b104edfb25f7--