Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id BDF3910AFF for ; Fri, 20 Dec 2013 17:29:59 +0000 (UTC) Received: (qmail 67864 invoked by uid 500); 20 Dec 2013 17:27:46 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 67469 invoked by uid 500); 20 Dec 2013 17:27:18 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 67349 invoked by uid 99); 20 Dec 2013 17:27:04 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Dec 2013 17:27:04 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [178.254.33.213] (HELO samaflost.de) (178.254.33.213) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 20 Dec 2013 17:26:58 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by samaflost.de (Postfix) with ESMTP id 55348588CA95 for ; Fri, 20 Dec 2013 18:26:37 +0100 (CET) Received: from samaflost.de ([127.0.0.1]) by localhost (v35516.1blu.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id smhDsd7WKMbC for ; Fri, 20 Dec 2013 18:26:36 +0100 (CET) Received: by samaflost.de (Postfix, from userid 1000) id 840D0588CA92; Fri, 20 Dec 2013 18:26:36 +0100 (CET) From: Stefan Bodewig To: "Commons Developers List" Subject: Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java References: <20131220171807.E722D23888FE@eris.apache.org> <52B47CB3.30202@apache.org> Date: Fri, 20 Dec 2013 18:26:36 +0100 In-Reply-To: <52B47CB3.30202@apache.org> (Emmanuel Bourg's message of "Fri, 20 Dec 2013 18:21:55 +0100") Message-ID: <8761qj8mcz.fsf@v35516.1blu.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On 2013-12-20, Emmanuel Bourg wrote: > Le 20/12/2013 18:18, ggregory@apache.org a =C3=A9crit : >> Remove some unnecessary parentheses. > I'd argue they make the code easier to read. Reading bit shifting code > is quite painful, some parentheses help greatly. +1 Stefan --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org