commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: [compress] cutting 1.7?
Date Fri, 20 Dec 2013 17:44:10 GMT
On 20 December 2013 17:38, Stefan Bodewig <bodewig@apache.org> wrote:
> On 2013-12-20, sebb wrote:
>
>> On 20 December 2013 17:07, Stefan Bodewig <bodewig@apache.org> wrote:
>>> On 2013-12-20, Gary Gregory wrote:
>
>>>> We get PMD warnings in
>>>> org.apache.commons.compress.archivers.jar.JarArchiveEntry about methods
>>>> only calling super.
>
>>>> Either document that the methods are placeholders for future
>>>> implementations (TODO) or remove the methods.
>
>>> Actually it is neither.  If you remove the methods findbugs will
>>> complain that JarEntry doesn't override equals() - it's a choice between
>>> Findbugs or PMD being unhappy.
>
>> Are you sure?
>
> Yes, I actually tried it again before sending my email.

I don't get a Findbugs error if I comment out the two methods.
I am using Findbugs 2.0.3 in Eclipse.

What Findbugs error do you get?

> Stefan
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message