commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1552745 - /commons/proper/compress/trunk/src/main/java/org/apache/commons/compress/compressors/z/ZCompressorInputStream.java
Date Fri, 20 Dec 2013 17:28:41 GMT
On 20 December 2013 17:21, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 20/12/2013 18:18, ggregory@apache.org a écrit :
>
>> Remove some unnecessary parentheses.
>
> I'd argue they make the code easier to read. Reading bit shifting code
> is quite painful, some parentheses help greatly.

In this case, the parentheses were around the whole expression, so did
not change the grouping visually.
In fact removing them here made it easier to read.

> Emmanuel
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message