commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Stefan Bodewig <bode...@apache.org>
Subject Re: [compress] Unused CRC in ZipArchiveInputStream
Date Thu, 19 Dec 2013 05:23:46 GMT
On 2013-12-19, Emmanuel Bourg wrote:

> ZipArchiveInputStream updates a CRC32 for each entry but the result is
> never used. Any objection to remove it?

Hmm, we also set the CRC on the ZipArchiveEntry so it may be worth to
actually verify it.  ZipFile doesn't verify it either, by the way.  I'd
prefer testing the CRC over removing it.

Stefan

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message