commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [VOTE] Release [pool] 2.1 based on RC1
Date Tue, 24 Dec 2013 20:35:08 GMT
Thanks for the review!

On 12/24/13, 10:22 AM, Gary Gregory wrote:
> +1
>
> BUT:
>
> - The Clirr breakage needs to be explained in the Overview page in a
> "Migrating from 2.0" section IMO.

Not sure that is necessary, but agree it needs to be mentioned /
explained in the release notes.
> - I also do not see anything in the change report like "Add method
> getBorrowedCount() to blah blah..."

That is what is meant by

 "Include the number of times an object has been borrowed from the
Pool when
   the DefaultPooledObject wrapper is used."

Probably the wording could be improved to make it clearer that this
is JMX property exposure.
> - There are two issues in the change report that do not include links to
> JIRA. Is that an omission or is there really no JIRA ticket?

I don't think there were JIRA tickets for these. 
> - It would be nice if the release notes file where reachable from the site.

The changes report is and it includes pretty much the same info.
>
> Gary
>
> Tested from the tag with:
>
> Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> 11:22:22-0400)
> Maven home: C:\Java\apache-maven-3.1.1\bin\..
> Java version: 1.7.0_45, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_45\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>
> Maven site build works. Reports look good.
>
>
> On Tue, Dec 24, 2013 at 12:21 AM, Phil Steitz <phil.steitz@gmail.com> wrote:
>
>> Pool 2.1 RC1 is available for review here:
>>   https://dist.apache.org/repos/dist/dev/commons/pool/
>>
>> Maven artifacts are here:
>>   https://repository.apache.org/content/repositories/orgapachecommons-019/
>>
>> Details of changes since 1.6 are in the release notes:
>>   https://dist.apache.org/repos/dist/dev/commons/pool/RELEASE-NOTES.txt
>>
>> The tag is here:
>>   http://svn.apache.org/repos/asf/commons/proper/pool/tags/POOL_2_1_RC1/
>>
>> Site:
>>   http://people.apache.org/~psteitz/pool/pool-2.1-rc1/ <
>> http://people.apache.org/%7Epsteitz/pool/pool-2.1-rc1/>
>>   (Broken links to Javadoc versions expected)
>>
>> Clirr Report:
>>   http://people.apache.org/~psteitz/pool/pool-2.1-rc1/clirr-report.html <
>> http://people.apache.org/%7Epsteitz/pool/pool-2.1-rc1/clirr-report.html>
>>
>> RAT:
>>   http://people.apache.org/~psteitz/pool/pool-2.1-rc1/rat-report.html <
>> http://people.apache.org/%7Epsteitz/pool/pool-2.1-rc1/rat-report.html>
>>
>>   Please review the release candidate and vote.
>>   This vote will close no sooner that 72 hours from now
>>
>>   [ ] +1 Release these artifacts
>>   [ ] +0 OK, but...
>>   [ ] -0 OK, but really should fix...
>>   [ ] -1 I oppose this release because...
>>
>> Thanks!
>>
>> Phil
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message