Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7817710718 for ; Wed, 20 Nov 2013 09:50:23 +0000 (UTC) Received: (qmail 74023 invoked by uid 500); 20 Nov 2013 09:50:21 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 73574 invoked by uid 500); 20 Nov 2013 09:50:20 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 73566 invoked by uid 99); 20 Nov 2013 09:50:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2013 09:50:20 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [87.98.171.146] (HELO mo6.mail-out.ovh.net) (87.98.171.146) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 20 Nov 2013 09:50:12 +0000 Received: from mail435.ha.ovh.net (b6.ovh.net [213.186.33.56]) by mo6.mail-out.ovh.net (Postfix) with SMTP id 36DCAFF9604 for ; Wed, 20 Nov 2013 10:51:05 +0100 (CET) Received: from b0.ovh.net (HELO queueout) (213.186.33.50) by b0.ovh.net with SMTP; 20 Nov 2013 11:50:45 +0200 Received: from mar75-7-82-247-19-29.fbx.proxad.net (HELO ?192.168.0.10?) (ebourg@ariane-software.com@82.247.19.29) by ns0.ovh.net with SMTP; 20 Nov 2013 11:50:45 +0200 Message-ID: <528C85BC.7030903@apache.org> Date: Wed, 20 Nov 2013 10:49:48 +0100 From: Emmanuel Bourg User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Commons Developers List Subject: Re: [VOTE] Release of Commons Collections 4.0 based on RC4 References: <52891787.2000802@gmail.com> <528C84D6.5020007@apache.org> In-Reply-To: <528C84D6.5020007@apache.org> X-Enigmail-Version: 1.6 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7wkHP6pgGjdSNwaIFvV3TG7I0PXqKveAF" X-Ovh-Tracer-Id: 9652621376513334338 X-Ovh-Remote: 82.247.19.29 (mar75-7-82-247-19-29.fbx.proxad.net) X-Ovh-Local: 213.186.33.20 (ns0.ovh.net) X-OVH-SPAMSTATE: OK X-OVH-SPAMSCORE: -100 X-OVH-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeiledrjedtucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecugfhvvghrhghhihhtvgdqqdetucdlqddutddtmd X-Spam-Check: DONE|U 0.5/N X-VR-SPAMSTATE: OK X-VR-SPAMSCORE: -100 X-VR-SPAMCAUSE: gggruggvucftvghtrhhoucdtuddrfeeiledrjedtucetufdoteggodetrfcurfhrohhfihhlvgemucfqggfjnecuuegrihhlohhuthemuceftddtnecugfhvvghrhghhihhtvgdqqdetucdlqddutddtmd X-Virus-Checked: Checked by ClamAV on apache.org --7wkHP6pgGjdSNwaIFvV3TG7I0PXqKveAF Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Also, I'm +1 for the release if this can be fixed later without breaking the compatibility. Emmanuel Bourg Le 20/11/2013 10:45, Emmanuel Bourg a =E9crit : > After an ultimate round of code review I have another observation > regarding the functor API. >=20 > In FalsePredicate the INSTANCE singleton is defined as > Predicate. In other predicates such as TruePredicate it's > defined as Predicate. In both cases this prevents the declaration of= : >=20 > Predicate predicate =3D FalsePredicate.INSTANCE; >=20 > This will fail to compile. >=20 > I suggest declaring the INSTANCE fields as ungenerified Predicates, suc= h > that the above example compiles with an unchecked warning. That's > similar to the EMPTY_LIST and similar constants in java.util.Collection= s. >=20 > Emmanuel Bourg --7wkHP6pgGjdSNwaIFvV3TG7I0PXqKveAF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.17 (MingW32) iQIcBAEBAgAGBQJSjIW9AAoJEPUTxBnkudCss/YP/ju1vTqTdUpNNjGXoA4DcG8L dnDpKOQb5TG1JeKb/fr8EokrFfeGAIsk6UFfTW1yeQsiLM8Lc/WbJz8FLgRY2awt vTDTazfcos2a0sIf/xc95DcF6VFechtTaKic/0i8PXDxyvnbrnBbwP6JvAlRGAwn v3jEIV2+70r2home2deYOUEVAg/vjfEPAnbZH9jb5EXX/mAyrj9oAsMqsVwr0cmm qRYhDB2yKURAxgwUEYVi/cgp/we/kw8kq1OFN4VAivLrrNZDPwtGH4fTUIpZKmzl SS2/ZkrWZz3e3CptL9uynQD5LWy4eTCYVqQWb7q/QVi7+2Iv0hOF665Ps205eSXJ N9h0SbetCDJvGO78Q7ObK82gDM4wfaF1RsWoinIqHIAp7uMjfNGmx/0M3wnhWQ1L znuAQLHYnmeOBBEs7SRQX2AP7VgkH9OLWekOytoU29bZukLVvqaAVw/raTSoXZe+ Q0x0TrC0aohp6hawvRlGIDGddMOzRAewHGApl0Bp07zoTCu2k2YuvkqDmtFLxhbb Qg2/kfBq62CSGwbIydHCaOReo3HLYDN3mVxdEYbgbWrn54HAVJNb5fo/HTqq5kPB ZGN1gEkwcILgaHUn0iCbzj0XgvHHUEOdHgoWthHIsfxlckiJXMr0X5w8mz92q7I/ LNieUgRL9hUzKD1GT+TC =Gj9n -----END PGP SIGNATURE----- --7wkHP6pgGjdSNwaIFvV3TG7I0PXqKveAF--