commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release of Commons Collections 4.0 based on RC5
Date Sat, 23 Nov 2013 15:29:17 GMT
On Sat, Nov 23, 2013 at 10:13 AM, Oliver Heger <oliver.heger@oliver-heger.de
> wrote:

> Hi Gary,
>
> Am 23.11.2013 15:56, schrieb Gary Gregory:
> > For those of you with +1's: Did you test the SVN tag or the src zip? Did
> > you see the same RAT issue I did?
> > Thank you,
> > Gary
>
> yes, I saw two unknown licenses in the RAT report. I was testing on
> windows. Maybe this depends on the platform?
>
> Anyway, this is certainly not a blocker.
>

Agreed, but rather odd that two files stand out where others with the same
extension in the same folder do not raise a flag. I just wonder if this is
symptomatic of something else.

Gary


>
> Oliver
>
> >
> >
> > On Sat, Nov 23, 2013 at 9:51 AM, Benedikt Ritter <britter@apache.org>
> wrote:
> >
> >> Hello Thomas,
> >>
> >> I've reviewed this RC with:
> >>
> >> Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
> >> 17:22:22+0200)
> >>
> >> Maven home: /Applications/dev/maven/apache-maven-3.1.1
> >>
> >> Java version: 1.7.0_45, vendor: Oracle Corporation
> >>
> >> Java home:
> >> /Library/Java/JavaVirtualMachines/jdk1.7.0_45.jdk/Contents/Home/jre
> >>
> >> Default locale: de_DE, platform encoding: UTF-8
> >>
> >> OS name: "mac os x", version: "10.9", arch: "x86_64", family: "mac"
> >>
> >>
> >> - Signatures are good
> >>
> >> - Tag and sources archives have the same content
> >>
> >> - Builds fine from sources
> >>
> >> - Page and Reports look good - There are some PMD und CPD violations,
> but I
> >> cannot judge how easy/hard they are to fix.
> >>
> >>
> >> My +1 for releasing the artifacts!
> >>
> >>
> >> Benedikt
> >>
> >>
> >>
> >>
> >> 2013/11/21 Thomas Neidhart <thomas.neidhart@gmail.com>
> >>
> >>> Hi,
> >>>
> >>> I'd like to call a vote for releasing Commons Collections 4.0 based on
> >>> RC5 and hope that people are still willing to review and vote for this
> >> RC.
> >>>
> >>>  Changes since RC4:
> >>>
> >>>   * [COLLECTIONS-502] Resolved generic parameter inconsistency for
> >>>     various static fields, e.g. BagUtils.EMPTY_BAG,
> >>>     TruePredicate.INSTANCE and many others. All accessible static
> >>>     fields use raw types so that they can be used directly without
> >>>     explicit casting. To avoid compiler warnings about unchecked
> >>>     conversion and/or rawtypes use the corresponding factory methods,
> >>>     e.g. BagUtils.emptyBag().
> >>>     Note: static fields where this was not possible, e.g.
> >>>     StringValueTransformer and InstantiateTransformer, have been made
> >>>     private to avoid problems. The factory methods should be used in
> >>>     these cases.
> >>>   * Cosmetic cleanups, removal of redundant stuff, e.g. imports, scope
> >>>     qualifiers in interfaces, implements by Gary Gregory.
> >>>
> >>>  Changes since RC3:
> >>>
> >>>   * [COLLECTIONS-501] Renamed methods "V MultiKeyMap#remove(Object,
> >>>     Object, ...)" to "V MultiKeyMap#removeMultiKey(Object, Object,
> >>>     ...)" to avoid future conflicts with a default method of the Map
> >>>     interface in Java 8.
> >>>   * [COLLECTIONS-500] Renamed "V MultiMap#remove(K, V)" to "boolean
> >>>     MultiMap#removeMapping(K, V)" to avoid future conflicts with a
> >>>     default method of the Map interface in Java 8.
> >>>   * fixed compilation problem with IBM JDK 5
> >>>   * fixed test failures with IBM JDK 6 by disabling some of them in
> >>>     case the tests are executed with such a JDK
> >>>   * added note to the release notes (textual version) wrt disabled
> tests
> >>>
> >>>  Changes since RC2:
> >>>
> >>>   * [COLLECTIONS-499] Refactored the test framework for Bag
> >>>     implementations to extend from "AbstractCollectionTest" by
> >>>     decorating the concrete Bag instance with a CollectionBag or
> >>>     CollectionSortedBag.
> >>>   * [COLLECTIONS-498] "CollectionBag" will now also respect the
> >>>     contract of the decorated bag in case a null argument is provided
> >>>     to either removeAll or retainAll.
> >>>   * [COLLECTIONS-497] Added bag decorator "CollectionSortedBag" which
> >>>     decorates a SortedBag to make it comply with the Collection
> >>>     contract.
> >>>   * [COLLECTIONS-496] "UnmodifiableBoundedCollection" does now also
> >>>     implement the marker interface "Unmodifiable" similar as all other
> >>>     unmodifiable decorators.
> >>>   * [COLLECTIONS-495] "UnmodifiableTrie#unmodifiableTrie(Trie)" will
> >>>     not decorate again an already unmodifiable Trie. Also the return
> >>>     type has been changed to "Trie" to be consistent with other
> >>>     Unmodifiable decorators.
> >>>   * [COLLECTIONS-494] Moved "Equator" interface to base package for
> >>>     consistency. Thanks to Emmanuel Bourg.
> >>>   * improved release notes with suggestions from Emmanuel Bourg
> >>>   * added unit tests for TrieUtils and QueueUtils and factory methods
> >>>     for all Unmodifiable decorators
> >>>   * added more unit tests for the Queue interface
> >>>   * cleanup of many test classes: removed unused imports, unneeded
> >>>     constructors
> >>>
> >>>  Changes since RC1:
> >>>
> >>>   * release notes are now also included in the binary distribution
> >>>   * removed spurious hashCode() method in AbstractPatriciaTrie, the
> >>>     inherited one from AbstractMap will be used instead
> >>>
> >>>
> >>>   Collections 4.0 RC5 is available for review here:
> >>>     https://dist.apache.org/repos/dist/dev/commons/collections/
> >>>     (svn revision 3628)
> >>>
> >>>   Maven artifacts are here:
> >>>
> >>>
> >>>
> >>
> https://repository.apache.org/content/repositories/orgapachecommons-162/org/apache/commons/commons-collections4/4.0/
> >>>
> >>>   The tag is here:
> >>>
> >>>
> >>>
> >>
> https://svn.apache.org/repos/asf/commons/proper/collections/tags/COLLECTIONS_4_0_RC5/
> >>>     (svn revision 1543981)
> >>>
> >>>   Site:
> >>>     http://people.apache.org/builds/commons/collections/4.0/RC5/
> >>>
> >>>   Details of changes can be found in the release notes:
> >>>
> >>>
> >>>
> >>
> https://dist.apache.org/repos/dist/dev/commons/collections/RELEASE-NOTES.txt
> >>>
> >>>
> >>
> http://people.apache.org/builds/commons/collections/4.0/RC5/changes-report.html
> >>>
> >>> Please review the release candidate and vote.
> >>> This vote will close no sooner than 72 hours from now.
> >>>
> >>>   [ ] +1 Release these artifacts
> >>>   [ ] +0 OK, but...
> >>>   [ ] -0 OK, but really should fix...
> >>>   [ ] -1 I oppose this release because...
> >>>
> >>> Note: the clirr report is generated against 4.0-alpha1 and it is also
> >>> highlighted in the release notes that this release is not compatible
> >>> with any previous release.
> >>>
> >>> Thank you for your reviews,
> >>>
> >>> Thomas
> >>>
> >>> ---------------------------------------------------------------------
> >>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> >>> For additional commands, e-mail: dev-help@commons.apache.org
> >>>
> >>>
> >>
> >>
> >> --
> >> http://people.apache.org/~britter/
> >> http://www.systemoutprintln.de/
> >> http://twitter.com/BenediktRitter
> >> http://github.com/britter
> >>
> >
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message