commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [VOTE] Release Imaging 1.0 from RC5
Date Fri, 01 Nov 2013 13:26:55 GMT
Hello Damjan,

I've build the RC with:

Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
17:22:22+0200)
Maven home: /Applications/dev/maven/apache-maven-3.1.1
Java version: 1.7.0_40, vendor: Oracle Corporation
Java home:
/Library/Java/JavaVirtualMachines/jdk1.7.0_40.jdk/Contents/Home/jre
Default locale: de_DE, platform encoding: UTF-8
OS name: "mac os x", version: "10.9", arch: "x86_64", family:"mac"


- builds fine,

- signatures are ok

- src archives and tag contain the same content

- Some points about the site: There are a lot of FindBugs and PMD
violations. The test coverage in parts of the code base is very low (< 50%)


I can not comment about FindBugs and PMD. Imaging is a relatively low level
library and I guess this kind of things are hard to fix when doing this
kind of computations. So this ist not a blocker for me (but others my see
this differently)


The low test coverage really gives me a bad feeling... But again I don't
know how hard it is to improve it.


That said I'm hesitant to vote with +1. I'd give you a +1 if at least the
low test coverage was fixed (at least more than 50% in every package would
be fine).


For releasing RC5 I vote +0.5.


Thanks for pushing this forward!


Benedikt


2013/11/1 Damjan Jovanovic <damjan@apache.org>

> Please vote on releasing commons-imaging 1.0 from RC5.
>
> RC4 and its problems and their fixes were in this thread:
>
> http://mail-archives.apache.org/mod_mbox/commons-dev/201209.mbox/%3CCAJm2B-nbnbJwNUKkAtapZuzT5jfFODsk1aXcdsUUeoC%2BxXrDKg%40mail.gmail.com%3E
> There were also many recent discussions on the development list.
>
> Imaging 1.0 RC5 is available here:
> https://dist.apache.org/repos/dist/dev/commons/imaging/ (SVN revision
> 3391)
>
> Maven artifacts:
>
> https://repository.apache.org/content/repositories/staging/org/apache/commons/commons-
> imaging/
>
> Change log(s):
> https://dist.apache.org/repos/dist/dev/commons/imaging/RELEASE-NOTES.txt
> http://people.apache.org/~damjan/imaging-1.0-RC5/changes-report.html
> http://people.apache.org/~damjan/imaging-1.0-RC5/jira-report.html
>
> Tag:
>
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC5
> <
> https://svn.apache.org/repos/asf/commons/proper/imaging/tags/IMAGING_1_0_RC4
> >(SVN
> revision 1537825)
>
> Site:
> http://people.apache.org/~damjan/imaging-1.0-RC5/<
> http://people.apache.org/%7Edamjan/imaging-1.0rc4/>
>
> I have tested it with OpenJDK 6 on FreeBSD 9.1.
>
> Please review and vote. This vote will close no sooner than 72 hours from
> now, on Monday 4 November 2013 at 12:00 GMT.
>
> [ ] +1 Release these artifacts
> [ ] +0 OK, but...
> [ ] -0 OK, but really should fix...
> [ ] -1 I oppose this release because...
>
> Thank you!
>
> Damjan Jovanovic
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message