commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Emmanuel Bourg <ebo...@apache.org>
Subject Re: svn commit: r1546303 - in /commons/proper/imaging/trunk/src/main/java/org/apache/commons/imaging: common/ common/bytesource/ common/itu_t4/ common/mylzw/ formats/bmp/pixelparsers/ formats/jpeg/decoder/ formats/pcx/ formats/png/ formats/tiff/ formats/ti...
Date Thu, 28 Nov 2013 08:42:01 GMT
Le 28/11/2013 08:45, Damjan Jovanovic a écrit :
> Why? I've heard initializing fields, even to their defaults, is a good
> practice and makes code clearer.

This style is applied to several components, it's reported by the
ExplicitInitialization checkstyle rule:

http://checkstyle.sourceforge.net/config_coding.html#ExplicitInitialization

"Rationale: each instance variable gets initialized twice, to the same
value. Java initializes each instance variable to its default value (0
or null) before performing any initialization specified in the code. So
in this case, x gets initialized to 0 twice, and bar gets initialized to
null twice. So there is a minor inefficiency. This style of coding is a
hold-over from C/C++ style coding, and it shows that the developer isn't
really confident that Java really initializes instance variables to
default values."

Emmanuel bourg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message