commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Phil Steitz <phil.ste...@gmail.com>
Subject Re: [jira] [Commented] (POOL-240) GKOP: invalidateObject does not unblock threads waiting in borrowObject
Date Tue, 26 Nov 2013 16:17:41 GMT
On 11/26/13, 4:09 AM, Mark Thomas wrote:
> On 25/11/2013 23:30, Phil Steitz wrote:
>> On 11/25/13, 3:17 PM, Gary Gregory wrote:
>>> Are we getting a 2.0.1 for this fix?
>> GKOP still needs to be fixed to resolve this and the GOP fix needs
>> the "TR" part of "CTR" done carefully ;).
> The GOP fix looks OK to me.
>
> Good catch with invalidateObject(). I hadn't noticed that.

I just committed a fix for GKOP.  I thought about just changing the
returnObject code to always call reuseCapacity instead of
immediately returning after destroying an object; but reuseCapacity
is a weaker liveness-enabler.  Calling addObject with the key of the
instance just destroyed seemed more reliable.

I am right that destroys on activation or validation failures during
borrow can't trigger this problem, right?  Might be good to add test
cases for this in any case.  I will get to that eventually, but if
this fix passes review I am OK resolving the issue.

Phil
>
> Mark
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message