commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [MATH] Interest in large patches for small cleanup / performance changes?
Date Sun, 03 Nov 2013 08:40:41 GMT
On 11/02/2013 06:35 PM, Sean Owen wrote:
> On Sat, Nov 2, 2013 at 4:49 PM, Phil Steitz <phil.steitz@gmail.com> wrote:
>> If the improvements make a material difference [1], by all means
>> open tickets and submit patches.  If they are just cosmetic, my
>> personal opinion is this should be done in small commits
>> incrementally if at all [2].  It is OK to open master tickets to
>> track style / optimization changes and do the work to review and
>> commit them incrementally.  The master ticket should be preceded by
>> discussion here to make sure we are all in agreement that the
>> changes are appropriate.
>>
>> You mention quite a few different kinds of thing above.  It is
>> probably best to break up into different discussion threads by
>> topical area and then open master tickets for the ones we agree to
>> fix / standardize.  Regarding the javadoc errors (broken javadoc
>> references, missing / incorrect @deprecates), there is no need for
>> discussion - just open tickets and we can commit the fixes.
> 
> I agree with that. I'm going to file two JIRAs and probably leave it
> for now. No point in getting into minutiae.
> 
> Let me turn it around: are there general clean-up tasks that people
> have wanted to do for a while but not gotten to? Maybe I could take a
> request or two and run with them.

Hi Sean,

imho the code is pretty clean and every committer takes a lot of effort
to keep it that way. Of course there are small little things here and
there that can be improved, as you noticed.

We have some areas that clearly need improvements:

 * userguide
 * examples

Sometimes the userguide is a bit out-of-date, or simply missing for a
package. I started with some examples under src/userguide, which is a
separate project with xchart as dependency to create graphs, which can
then also be used in the userguide.

If you are interested in working on some examples how to use
commons-math in a real-world scenario or improving the userguide, would
be awesome.

Other, maybe more interesting things are providing patches for open
issues / feature requests. You may also want to take a look at the

https://wiki.apache.org/commons/MathWishList

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message