Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of jak-commons-dev@m.gmane.org
 designates 80.91.229.3 as permitted sender)
To: dev@commons.apache.org
From: =?UTF-8?B?SsO2cmc=?= Schaible <joerg.schaible@gmx.de>
Subject: Re: [imaging] Closing stream
Date: Thu, 24 Oct 2013 22:31:47 +0200
Lines: 26
Message-ID: <l4c03a$cqt$1@ger.gmane.org>
References: 
 <CACZkXPxz3fQjtFfDc5d43L7Sz3hC-70BZPXmgEY-REcNvO5mmw@mail.gmail.com>
 <CAOGo0VZ=otGkoex-oSodaTimU4njr1acFdpTD5QNy2+gG2wqKw@mail.gmail.com>
 <CACZkXPyd_sF3oyEHqFbHKpUnM2GSwZ7FTkUQhgT2HO+2oMAf2g@mail.gmail.com>
 <CAJm2B-kdKdx5dqV=yAfbGCF0=4ugzLe3_Qhc+fcECim8HTJOtg@mail.gmail.com>
Reply-To: joerg.schaible@gmx.de
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8Bit
User-Agent: KNode/4.10.5

Hi Damjan,

Damjan Jovanovic wrote:

> As one of the perpetrators of the problem, I have now fixed it. The
> reasons I swallowed exceptions were simple:

[snip]

> * when an exception is thrown and close() then throws another
> exception, the close() exception is propagated and the original
> exception - which could reveal the cause of the problem - swallowed

[snip]

And this *is* a real problem. And it is exactly why the IOException of 
close() are normally ignored. While I don't like 
IOUtils.closeQietly(closeable), I use normally a method 
"IO.closeLogged(closeable)" resp. "IO.closeLogged(closeable, logger)".

If e.g. an image is corrupted and later on an additional exception occurs 
closing any resource, you will simply *never* learn about the corrupted 
image that caused the problem in first case. The original exception must 
never be swallowed!

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org