Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates
 74.125.82.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CALznzY7YFoMK8W8-wxc1St+FO_zcZscieksQrnKisn9UQ7SF0A@mail.gmail.com>
References: <20131002201230.2F3CD23888A6@eris.apache.org>
	<CAOGo0Va=dg5vu+_7KeBdG+wD=fxxEECP3hacmYwRc7=smbUHYg@mail.gmail.com>
	<CAGFtjw3DfJ7scpPdPSu4jk1cywTV=FUKJFaBv5Hw0VLqusuVog@mail.gmail.com>
	<CAOGo0VZqRW1t8QssbSAvoYJTr9j4UmYW15kFOQBYLi_OMas5Ng@mail.gmail.com>
	<CACLE=7MUoO1TSsao1XHdSQwmASh=Qhoey0R52nSs6oUCaX0ORA@mail.gmail.com>
	<CAOGo0VZr+3_+FhC71TCO8G-VmGemxvmtfmZLn9gAM9xL_Tjnnw@mail.gmail.com>
	<CALznzY7YFoMK8W8-wxc1St+FO_zcZscieksQrnKisn9UQ7SF0A@mail.gmail.com>
Date: Fri, 4 Oct 2013 23:46:16 +0100
Message-ID: 
 <CAOGo0VYs6gfvsA8ft9Dn_RPTpHBj0eSSj=TKkoac8i+k2jZPzA@mail.gmail.com>
Subject: Re: svn commit: r1528612 -
 /commons/sandbox/monitoring/trunk/reporting/src/main/java/org/apache/commons/monitoring/reporting/web/plugin/PluginRepository.java
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On 4 October 2013 23:23, James Carman <james@carmanconsulting.com> wrote:
> On Fri, Oct 4, 2013 at 6:11 PM, sebb <sebbaz@gmail.com> wrote:
>>
>> Back to the case in point: why is the string ".activate" and not anything else?
>>
>
> Why not just extract a constant and name it something logical like
> "ACTIVATED_INDICATOR"?  Then, the actual value of the constant can be
> whatever you want.  The value of the string isn't important (other
> than making it a bit more human-readable of course).  What is
> important is that you use the string in a consistent fashion
> throughout your code.  By not using a constant, it makes it more
> likely to fat-finger the value when you type it again somewhere.
> Anyway, I'm sure I'm not telling you anything new.  I just don't think
> it's relevant to go into a lengthy discussion about the string that's
> used as some sort of marker.  Just extract the constant (and use it)
> and move on.

That was exactly my point.
However, I don't think the value is arbitrary, given that it is only used once.
It looks to me as though the code is relying on some external
convention for property naming.

> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org