Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of beneritter@gmail.com designates
 209.85.214.53 as permitted sender)
Subject: Re: svn commit: r1528612 -
 /commons/sandbox/monitoring/trunk/reporting/src/main/java/org/apache/commons/monitoring/reporting/web/plugin/PluginRepository.java
References: <20131002201230.2F3CD23888A6@eris.apache.org>
 <CAOGo0Va=dg5vu+_7KeBdG+wD=fxxEECP3hacmYwRc7=smbUHYg@mail.gmail.com>
 <CAGFtjw3DfJ7scpPdPSu4jk1cywTV=FUKJFaBv5Hw0VLqusuVog@mail.gmail.com>
 <CAOGo0VZqRW1t8QssbSAvoYJTr9j4UmYW15kFOQBYLi_OMas5Ng@mail.gmail.com>
 <CACLE=7MUoO1TSsao1XHdSQwmASh=Qhoey0R52nSs6oUCaX0ORA@mail.gmail.com>
 <CAOGo0VZr+3_+FhC71TCO8G-VmGemxvmtfmZLn9gAM9xL_Tjnnw@mail.gmail.com>
 <CALznzY7YFoMK8W8-wxc1St+FO_zcZscieksQrnKisn9UQ7SF0A@mail.gmail.com>
 <CALznzY44eifBHCAbnMgvsPyN=rVM32=iWL4Q-ERPmNR9DdMMPg@mail.gmail.com>
From: Benedikt Ritter <beneritter@gmail.com>
Content-Type: text/plain;
	charset=us-ascii
In-Reply-To: 
 <CALznzY44eifBHCAbnMgvsPyN=rVM32=iWL4Q-ERPmNR9DdMMPg@mail.gmail.com>
Message-Id: <A82DC2AF-B801-47E5-8AF7-EB89CDCCC40C@gmail.com>
Date: Sat, 5 Oct 2013 13:03:06 +0200
To: Commons Developers List <dev@commons.apache.org>
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0 (1.0)

Hi James,

Send from my mobile device

> Am 05.10.2013 um 00:33 schrieb James Carman <james@carmanconsulting.com>:
>=20
> Also, since when did we start nit-picking code in the sandbox?  Why
> not leave these folks alone and let them work out their ideas?  The
> sandbox should be an area where folks can play around with stuff and
> share new ideas without being hassled by folks.  If we make it a pain
> in the butt, then people will just go elsewhere with their cool ideas.
> It's one thing if you're collaborating on the project, but trolling
> commit logs and picking out things you don't like is just plain rude,
> IMHO.

I'm not sure I agree with all of your points. Yes, the sandbox is a place to=
 try new ideas out. Does this mean certain quality criterions do not apply? I=
 don't think so. This all has to be corrected before promotion, so why not m=
ake it correct right from the start?

Is pointing out that something may be improved nit-picking? Well, I think it=
 depends :-) Just sending a -1 for a commit like this would definitely be. I=
n this case an improvement has been pointed out. I'm more then happy for fee=
dback like this, because it helps me become a better developer. And in the e=
nd, discussing commits is part of the game ;-)

Regards,
Benedikt

>=20
>> On Fri, Oct 4, 2013 at 6:23 PM, James Carman <james@carmanconsulting.com>=
 wrote:
>>> On Fri, Oct 4, 2013 at 6:11 PM, sebb <sebbaz@gmail.com> wrote:
>>>=20
>>> Back to the case in point: why is the string ".activate" and not anythin=
g else?
>>=20
>> Why not just extract a constant and name it something logical like
>> "ACTIVATED_INDICATOR"?  Then, the actual value of the constant can be
>> whatever you want.  The value of the string isn't important (other
>> than making it a bit more human-readable of course).  What is
>> important is that you use the string in a consistent fashion
>> throughout your code.  By not using a constant, it makes it more
>> likely to fat-finger the value when you type it again somewhere.
>> Anyway, I'm sure I'm not telling you anything new.  I just don't think
>> it's relevant to go into a lengthy discussion about the string that's
>> used as some sort of marker.  Just extract the constant (and use it)
>> and move on.
>=20
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>=20

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org