commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Henri Yandell <flame...@gmail.com>
Subject Re: [LANG] Findbugs and CheckStyle
Date Thu, 24 Oct 2013 06:44:34 GMT
Noting that we've not stopped having Findbugs, Checkstyle and PMD notes
from blocking a release in the past if we didn't agree with them.

Checkstyle should get improved, but it's not a regression (ie: 3.2 would be
no worse than 3.1).

Hen


On Wed, Oct 23, 2013 at 11:21 PM, Benedikt Ritter <britter@apache.org>wrote:

> Hi guys,
>
> there are only two issues left in jira which can be fixed later than 3.2.
> If you agree feel free to change the Fix version, so that we can move on.
> I've looked through FindBugs and CheckStyle:
>
> CheckStyle: only missing JavaDoc in TypeUtils. To be honest I really don't
> know what the reflection magic in TypeUtils does, so I don't know how to
> document that. Matt, would you be so kind to add the last missing bits? You
> seem to have an understanding of what is going on there. BTW: one thing I
> don't like about TypeUtils is that is does not do input parameter
> validation like other Utils in lang do. This makes it fail late, which may
> lead to obscure stack traces. Maybe we should file an issue for that.
>
> FindBugs: It complains mostly about switch statements with a missing
> default case. I've look through one or two and those had a default case.
> Maybe FindBugs isn't able to figure that out because there is are comments
> like: // $ FALL-THROUGH (probably related to PMD?!). Any idea about that?
> The other issue is a String comparison using == instead of equals in
> DurationFormatUtils. I've looked into that as well and it looks like this
> is some kind of weird performance optization. IMHO it is really hard to
> understand to say the least. Can we supress this warning?
>
> Let's just fix this stuff and cut an RC :)
>
> Benedikt
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message