commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1530336 - /commons/proper/jci/trunk/fam/src/test/java/org/apache/commons/jci/monitor/FilesystemAlterationMonitorTestCase.java
Date Tue, 08 Oct 2013 20:02:05 GMT
On 8 October 2013 17:11,  <ebourg@apache.org> wrote:
> Author: ebourg
> Date: Tue Oct  8 16:11:41 2013
> New Revision: 1530336
>
> URL: http://svn.apache.org/r1530336
> Log:
> Disabled an assertion in testDeleteFileDetection failing on Windows (this is not a regression,
the same assertion fails with JCI 1.0)
>
> Modified:
>     commons/proper/jci/trunk/fam/src/test/java/org/apache/commons/jci/monitor/FilesystemAlterationMonitorTestCase.java
>
> Modified: commons/proper/jci/trunk/fam/src/test/java/org/apache/commons/jci/monitor/FilesystemAlterationMonitorTestCase.java
> URL: http://svn.apache.org/viewvc/commons/proper/jci/trunk/fam/src/test/java/org/apache/commons/jci/monitor/FilesystemAlterationMonitorTestCase.java?rev=1530336&r1=1530335&r2=1530336&view=diff
> ==============================================================================
> --- commons/proper/jci/trunk/fam/src/test/java/org/apache/commons/jci/monitor/FilesystemAlterationMonitorTestCase.java
(original)
> +++ commons/proper/jci/trunk/fam/src/test/java/org/apache/commons/jci/monitor/FilesystemAlterationMonitorTestCase.java
Tue Oct  8 16:11:41 2013
> @@ -228,7 +228,7 @@ public final class FilesystemAlterationM
>          listener.waitForCheck();
>
>          assertEquals("expecting 1 file created", 1, listener.getCreatedFiles().size());
> -        assertEquals("expecting 0 directories changed", 0, listener.getChangedDirectories().size());
> +        //assertEquals("expecting 0 directories changed", 0, listener.getChangedDirectories().size());
// todo investigate why this is failing on Windows

It works OK for me on Windows.

But in any case, I think it would be better to always check the condition.
The changed directories should then be logged to get a better idea of
what went wrong.
Could then continue on Windows and fail elsewhere.

>
>          file.delete();
>          assertFalse("file should not exist", file.exists());
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message