commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: svn commit: r1524435 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVParser.java test/java/org/apache/commons/csv/CSVParserTest.java
Date Wed, 18 Sep 2013 19:32:20 GMT
2013/9/18 Emmanuel Bourg <ebourg@apache.org>

> Le 18/09/2013 16:57, ggregory@apache.org a écrit :
>
> >      public Map<String, Integer> getHeaderMap() {
> > -        return new LinkedHashMap<String, Integer>(this.headerMap);
> > +        return this.headerMap == null ? null : new
> LinkedHashMap<String, Integer>(this.headerMap);
> >      }
> >
>
> Would it be possible to use an UnmodifiableMap for headerMap? That would
> avoid the need to copy the map on calling getHeaderMap().
>

Furthermore the contributor should be added to pom.xml and changes.xml.

Benedikt


>
> Emmanuel Bourg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message