commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1513484 - in /commons/proper/vfs/trunk: core/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilder.java src/changes/changes.xml
Date Tue, 13 Aug 2013 14:04:45 GMT
On 13 August 2013 14:43,  <ggregory@apache.org> wrote:
> Author: ggregory
> Date: Tue Aug 13 13:43:41 2013
> New Revision: 1513484
>
> URL: http://svn.apache.org/r1513484
> Log:
> [VFS-265][FTP] Set user dir as root dir by default.
>
> Modified:
>     commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilder.java
>     commons/proper/vfs/trunk/src/changes/changes.xml
>
> Modified: commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilder.java
> URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilder.java?rev=1513484&r1=1513483&r2=1513484&view=diff
> ==============================================================================
> --- commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilder.java
(original)
> +++ commons/proper/vfs/trunk/core/src/main/java/org/apache/commons/vfs2/provider/ftp/FtpFileSystemConfigBuilder.java
Tue Aug 13 13:43:41 2013
> @@ -209,13 +209,16 @@ public class FtpFileSystemConfigBuilder
>      }
>
>      /**
> -     * @param opts The FileSystemOptions.
> -     * @return true if the user directory is treated as the root.
> +     * Returns <code>true</code> if VFS treats the user directory as the
root directory. Defaults to <code>true</code>.

Again, it's not clear from the Javadoc what might cause the default to
be applied.

> +     *
> +     * @param opts
> +     *            The FileSystemOptions.
> +     * @return <code>true</code> if VFS treats the user directory as the
root directory. Defaults to <code>true</code>.
>       * @see #setUserDirIsRoot
>       */
>      public Boolean getUserDirIsRoot(final FileSystemOptions opts)
>      {
> -        return getBoolean(opts, USER_DIR_IS_ROOT);
> +        return getBoolean(opts, USER_DIR_IS_ROOT, Boolean.TRUE);
>      }
>
>      /**
>
> Modified: commons/proper/vfs/trunk/src/changes/changes.xml
> URL: http://svn.apache.org/viewvc/commons/proper/vfs/trunk/src/changes/changes.xml?rev=1513484&r1=1513483&r2=1513484&view=diff
> ==============================================================================
> --- commons/proper/vfs/trunk/src/changes/changes.xml (original)
> +++ commons/proper/vfs/trunk/src/changes/changes.xml Tue Aug 13 13:43:41 2013
> @@ -26,6 +26,9 @@
>  <!--       <action issue="VFS-443" dev="ggregory" type="update" due-to="nickallen">
-->
>  <!--           [Local] Need an easy way to convert from a FileObject to a File. -->
>  <!--       </action> -->
> +      <action issue="VFS-265" dev="ggregory" type="update" due-to="Scott Bjerstedt">
> +        [FTP] Set user dir as root dir by default.
> +      </action>
>        <action issue="VFS-489" dev="ggregory" type="fix" due-to="Bernd Eckenfels">
>          [tests] ProviderWriteTests#testListener does not fail cleanly.
>        </action>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message