commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject [CSV] Use UTF-8 as the default Charset if no Charset is specified?
Date Fri, 30 Aug 2013 14:45:42 GMT
Hi,

in r1518802 [1] I have introduced some parameter validation. This was the
result of a discussion we had some time ago [2], where we agreed there
shouldn't be any fallbacks if null is passed to one of the static creation
methods on CSVParser. Now there is one method left that still uses a
fallback:

public static CSVParser parse(URL url, Charset charset, final CSVFormat
format)

This method falls back to Charset.forName("UTF-8") if null is passed in for
charset. Since other methods don't use fall backs I wonder if we should
remove the fallback logic here as well.

Benedikt

[1] http://svn.apache.org/r1518802
[2] http://markmail.org/message/rajn6auovzc55w4r


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message