Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D9C8710E23 for ; Wed, 24 Jul 2013 10:41:45 +0000 (UTC) Received: (qmail 60693 invoked by uid 500); 24 Jul 2013 10:41:44 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 60615 invoked by uid 500); 24 Jul 2013 10:41:44 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 60233 invoked by uid 99); 24 Jul 2013 10:41:43 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jul 2013 10:41:43 +0000 Received: from localhost (HELO [192.168.23.9]) (127.0.0.1) (smtp-auth username markt, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Jul 2013 10:41:42 +0000 Message-ID: <51EFAF61.9030305@apache.org> Date: Wed, 24 Jul 2013 11:41:37 +0100 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130620 Thunderbird/17.0.7 MIME-Version: 1.0 To: dev@commons.apache.org Subject: Re: svn commit: r1506488 - in /commons/proper/pool/trunk/src: main/java/org/apache/commons/pool2/ main/java/org/apache/commons/pool2/impl/ test/java/org/apache/commons/pool2/impl/ References: <20130724103710.C34A8238888A@eris.apache.org> In-Reply-To: <20130724103710.C34A8238888A@eris.apache.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 24/07/2013 11:37, markt@apache.org wrote: > Author: markt > Date: Wed Jul 24 10:37:09 2013 > New Revision: 1506488 > > URL: http://svn.apache.org/r1506488 > Log: > Make PooledObject an interface so it can be used in the Factory implementations. In case anyone is wondering where I am heading with this, this is a step towards fixing DBCP-156. By making the pooled object available to the factory, the factory can implement a validation rule along the lines of "no object older than x hours". That particular rule could be implemented by the factory keeping track of every object and its creation time but since the PooledObject already has the information I think it makes sense to re-use it and keep all the pooled object state information in one place. It also allows for more complex state based validation rules. Mark --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org