Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of ted.dunning@gmail.com
 designates 209.85.223.182 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <d94258cbd34131e5bee7706f16b27a52@scarlet.be>
References: 
 <CAOOSspget8kcriyvBaGKqzedKtokeRSBWDXnj5ZO0T5HohSAYg@mail.gmail.com>
 <d94258cbd34131e5bee7706f16b27a52@scarlet.be>
From: Ted Dunning <ted.dunning@gmail.com>
Date: Fri, 28 Jun 2013 08:32:49 -0700
Message-ID: 
 <CAJwFCa2uF7k_A9Z1O3_dDgZY+rT4bS5EmVhmG+EVHS1D6GQHUg@mail.gmail.com>
Subject: Re: [math] On MATH-995: Problems with LegendreGaussQuadrature class.
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=047d7b4182853459d104e03899ea

--047d7b4182853459d104e03899ea
Content-Type: text/plain; charset=UTF-8

On Fri, Jun 28, 2013 at 8:14 AM, Gilles <gilles@harfang.homelinux.org>wrote:

> Hello.
>
>  The existing LegendreGaussQuadrature class incorrectly assumes that it has
>> converged for functions where the polynomial approximation fails in a
>> small
>> corner of the integral space.
>>
>> This situation is handled much better with the AdaptiveQuadrature class in
>> the path for MATH-995. This problem should be observable with any
>> integral,
>> but I observed it with an improper integral. The patch in MATH-995
>> transforms the improper integral to a proper one before applying the
>> LegendreGaussQuadrature class (to show how it fails). It also computes the
>> same proper integral with the Adaptive method to show the proper behavior.
>>
>
> Please note that CM aims at providing _standard_ algorithms.[1]
>
> Wikipedia has this general article:
>   https://en.wikipedia.org/wiki/**Adaptive_quadrature<https://en.wikipedia.org/wiki/Adaptive_quadrature>
> where it is mentioned that the problem is broken into
> * standard quadrature rules,
> * logic to subdivide the interval and terminate the algorithm.
>
> As I explained in the other post we must aim at flexibility. In this
> case, that would indeed imply a clean separation, as outlined in the
> article referred to above. [This is obviously not the case in your
> "AdaptiveQuadrature" class.]
>

Gilles,

This guy is reporting a problem with LGQ and you seem to jump on him for
coding style.

Isn't the correct response more along the lines of "Hmm.... interesting
discrepancy.  Need to check on it"?

--047d7b4182853459d104e03899ea--