Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00DA4103E9 for ; Tue, 11 Jun 2013 20:00:31 +0000 (UTC) Received: (qmail 8561 invoked by uid 500); 11 Jun 2013 20:00:30 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 8476 invoked by uid 500); 11 Jun 2013 20:00:30 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 8467 invoked by uid 99); 11 Jun 2013 20:00:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 20:00:30 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of simone.tripodi@gmail.com designates 209.85.214.175 as permitted sender) Received: from [209.85.214.175] (HELO mail-ob0-f175.google.com) (209.85.214.175) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Jun 2013 20:00:25 +0000 Received: by mail-ob0-f175.google.com with SMTP id xn12so12125238obc.6 for ; Tue, 11 Jun 2013 13:00:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=2VSLytZz65WnSwRxYbAUwU1TPmnIyQKVf9LsD7QyoOs=; b=0fXyQPBegBlX1Sc95lDXj4FNT9gdeW1isL/ycvPAea1qGb/WVYd0faHPYGvzno1kM6 oGPk0niWdJBTSW6oGOuX8nG7RFFj3rreH50jprvA8LyLuNUtSNN3oP2/YPxWibEURVP+ 6q7EIjltqWHNxSJYbXHQynHkJGzo1uHb5/hTcEDI6WSXmSKBn6BGR8tJ+Zf7A0T7WQfq JGeeFPV7mctxjTZQrv/e2mOcQNH8xDl/4kBez1r2ghQAPlcZv9cY+U2T8zn7YZpt06hH Lgy906hbskVeuwx/b2OQBL85NSnfER+Gwc6Rl2liTWeScHYprycfkQ88bj4JQSpgNADL E+0Q== MIME-Version: 1.0 X-Received: by 10.60.142.103 with SMTP id rv7mr13106035oeb.34.1370980804646; Tue, 11 Jun 2013 13:00:04 -0700 (PDT) Sender: simone.tripodi@gmail.com Received: by 10.60.147.198 with HTTP; Tue, 11 Jun 2013 13:00:04 -0700 (PDT) In-Reply-To: <286AD3C4-9D4D-4C4D-8292-7E27FD4BF43B@gmail.com> References: <20130611194716.86FE5238889B@eris.apache.org> <286AD3C4-9D4D-4C4D-8292-7E27FD4BF43B@gmail.com> Date: Tue, 11 Jun 2013 22:00:04 +0200 X-Google-Sender-Auth: wMvlAJJikniw6C9HUNCHPsEDKq8 Message-ID: Subject: Re: svn commit: r1491924 - /commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java From: Simone Tripodi To: Commons Developers List Content-Type: text/plain; charset=UTF-8 X-Virus-Checked: Checked by ClamAV on apache.org I usually don't take too much care to this kind of warnings... My opinion is you can feel free to keep the best option you like :P best and thanks, -Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Tue, Jun 11, 2013 at 9:50 PM, Benedikt Ritter wrote: > This will cause warnings in client code, so better revert it? > > Am 11.06.2013 um 21:47 schrieb britter@apache.org: > >> Author: britter >> Date: Tue Jun 11 19:47:16 2013 >> New Revision: 1491924 >> >> URL: http://svn.apache.org/r1491924 >> Log: >> Use var args instead of array as parameter >> >> Modified: >> commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java >> >> Modified: commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java >> URL: http://svn.apache.org/viewvc/commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java?rev=1491924&r1=1491923&r2=1491924&view=diff >> ============================================================================== >> --- commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java (original) >> +++ commons/proper/chain/trunk/core/src/main/java/org/apache/commons/chain2/impl/ChainBase.java Tue Jun 11 19:47:16 2013 >> @@ -69,7 +69,7 @@ public class ChainBase> * or one of the individual {@link Command} elements, >> * is null >> */ >> - public ChainBase(Command[] commands) { >> + public ChainBase(Command... commands) { >> if (commands == null) { >> throw new IllegalArgumentException(); >> } >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org