Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sprengerj22@gmail.com
 designates 209.85.215.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CALy1bpe2utfd-181wBEyZ7Zv1LNTvLr3fimOtyvSy_UASD8uRg@mail.gmail.com>
References: 
 <CAB917RKNeyBEo0i_4KtCGSD09rd_ewf=4B8aiWpeEEhWM+eYJw@mail.gmail.com>
	<CAAqLGLO90wDZwoV7S8k93m8q=SB=kx1jNL9UBM8FZVgycrCxtw@mail.gmail.com>
	<CA+=AaSK3yzubf5fvg0HyS+AOc2Jr5WR3dM085Yy05rytTicbNA@mail.gmail.com>
	<CAAqLGLNObyhSr57HViAE5cph6KUf86Gqzc=04fJA8MSFpvW7mQ@mail.gmail.com>
	<CAB917R+gBrN=yXAtUi0sSOoZ43o+iP__rVOwQHBR6HhYs68F=g@mail.gmail.com>
	<CAAqLGLMy+Q2PS7RyXcJj_XuWTvMbfgJiR2=Gy2AWmf803jKWEw@mail.gmail.com>
	<CA+=AaSJAFmS9BvJ-DmOjz3j3=jBs56E8FqgDESAsg2dYm_Q=4g@mail.gmail.com>
	<CAAqLGLPzbSuh12UTkjW7dzatuyA9JeZUD3snt2ez0tGy26T2Gg@mail.gmail.com>
	<70BFF8B2-E852-4ACA-ADA6-E3AC5B033602@gmail.com>
	<CALy1bpe2utfd-181wBEyZ7Zv1LNTvLr3fimOtyvSy_UASD8uRg@mail.gmail.com>
Date: Thu, 27 Jun 2013 10:02:05 +0200
Message-ID: 
 <CA+=AaSJwMnLXiCzZ=8SR8+L6ucmhETcE6LaGvEAOfMv_VyEbXQ@mail.gmail.com>
Subject: Re: [CHAIN] Thoughts about o.a.c.chain2.Chain, o.a.c.chain2.Command
 and the base classes
From: Jonas Sprenger <sprengerj22@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=001a1133c69095bae404e01e2dc0

--001a1133c69095bae404e01e2dc0
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: quoted-printable

Hi Elijah,

The =91Continue=92 and =91Completed=92 values look very similar to me, espe=
cially
in Unit tests. I suggest naming the two states:
- Continue
- Finished
>With regards to an enum for status, wouldn't it be better to use a class s=
o
>that consumers could subclass it and add their own states if needed?

As far as I know, there is not a decision about the third state 'Aborted'
yet. So the question is, do the 3 states cover the complete set of possible
values? Implementing the exception handling might show the need for more
states.

I would suggest sticking with the enum for now. The refactoring from an
enum to a interface =91Processing=92 is not that big deal.

regards,
Jonas

2013/6/26 Elijah Zupancic <elijah@zupancic.name>

> +1 to everything.
>
> With regards to an enum for status, wouldn't it be better to use a class =
so
> that consumers could subclass it and add their own states if needed?
>
> Thanks,
> -Elijah
>
>
> On Sat, Jun 22, 2013 at 4:30 AM, Benedikt Ritter <beneritter@gmail.com
> >wrote:
>
> >
> > Am 22.06.2013 um 12:57 schrieb Simone Tripodi <simonetripodi@apache.org
> >:
> >
> > > Hi Jonas,
> > >
> > >>
> > >> I will provide a patch for
> > >> CHAIN-98<https://issues.apache.org/jira/browse/CHAIN-98>tomorow. The
> > >> patch will only cover the refactoring of CONTINUE and
> > >> COMPLETED processing results.
> > >>
> > >
> > > nice to read that, looking forward to the patch! :)
> > >
> > >> But, I do not understand how exceptions should be handled in this
> > context.
> > >> A exception listener filters the exceptions and returns ABORTED if
> > >> appropriate?
> > >
> > > let's postpone it and keep CONTINUE and COMPLETED only ATM - Benedikt
> > > is working on an exception listener, let's see how it evolves and
> > > let's evaluate later if/how ABORTED will be introduced.
> >
> > Yeah, well I'm not really working on it. But I'll do as soon as I got t=
he
> > time :)
> >
> > Benedikt
> >
> > >
> > > Thanks in advance, all the best!
> > > -Simo
> > >
> > > http://people.apache.org/~simonetripodi/
> > > http://twitter.com/simonetripodi
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > > For additional commands, e-mail: dev-help@commons.apache.org
> > >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
> >
>
>
> --
> -Elijah
>

--001a1133c69095bae404e01e2dc0--