Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of beneritter@gmail.com designates
 209.85.214.43 as permitted sender)
Content-Type: text/plain; charset=windows-1252
Mime-Version: 1.0 (Mac OS X Mail 6.5 \(1508\))
Subject: Re: [CHAIN] CopyCommand implements two commands at once
From: Benedikt Ritter <beneritter@gmail.com>
In-Reply-To: <ABE2EAD0-BB1D-44B4-B751-70491D36DA76@gmail.com>
Date: Tue, 18 Jun 2013 21:06:59 +0200
Content-Transfer-Encoding: quoted-printable
Message-Id: <9134CCA2-B1E7-4EDE-90A0-C562837BCAEC@gmail.com>
References: <9B198150-A444-4E65-BFE9-A1DD6CAE8FFE@gmail.com>
 <6A0DF379-7414-45A7-963B-685BB5F3EAE9@gmail.com>
 <ABE2EAD0-BB1D-44B4-B751-70491D36DA76@gmail.com>
To: "dev@commons.apache.org List" <dev@commons.apache.org>


Am 16.06.2013 um 13:46 schrieb Benedikt Ritter <beneritter@gmail.com>:

>=20
> Am 15.06.2013 um 15:52 schrieb Benedikt Ritter <beneritter@gmail.com>:
>=20
>>=20
>> Am 14.06.2013 um 22:36 schrieb Benedikt Ritter =
<beneritter@gmail.com>:
>>=20
>>> Hi,
>>>=20
>>> the o.a.c.chain2.generic.CopyCommand IMHO really implements two =
commands:
>>>=20
>>> * a CopyCommand that copies a value from one key to another
>>> * an OverrideCommand, that overrides a value with a provided value.
>>=20
>> We could even extract a RemoveCommand from CopyCommand. A =
RemoveCommand simply removes getKey() from the context.
>=20
> I have created CHAIN-91 [1] for this. If no one objects, I'll =
implement this tonight.

Just realized we already have a RemoveCommand=85 So no need to =
reimplement it. I think is makes sense to remove the =
"remove"-functionality from CopyCommand then...

>=20
> Benedikt
>=20
> [1] https://issues.apache.org/jira/browse/CHAIN-91
>=20
>>=20
>>>=20
>>> What do you think about splitting this up into two separate classes?
>>>=20
>>> Regards,
>>> Benedikt
>>=20
>=20


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org