commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <benerit...@gmail.com>
Subject Re: [CHAIN] CopyCommand implements two commands at once
Date Sun, 16 Jun 2013 11:46:18 GMT

Am 15.06.2013 um 15:52 schrieb Benedikt Ritter <beneritter@gmail.com>:

> 
> Am 14.06.2013 um 22:36 schrieb Benedikt Ritter <beneritter@gmail.com>:
> 
>> Hi,
>> 
>> the o.a.c.chain2.generic.CopyCommand IMHO really implements two commands:
>> 
>> * a CopyCommand that copies a value from one key to another
>> * an OverrideCommand, that overrides a value with a provided value.
> 
> We could even extract a RemoveCommand from CopyCommand. A RemoveCommand simply removes
getKey() from the context.

I have created CHAIN-91 [1] for this. If no one objects, I'll implement this tonight.

Benedikt

[1] https://issues.apache.org/jira/browse/CHAIN-91

> 
>> 
>> What do you think about splitting this up into two separate classes?
>> 
>> Regards,
>> Benedikt
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message