Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of sebbaz@gmail.com designates
 209.85.215.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <519DA0B7.7090304@gmail.com>
References: 
 <CACZkXPzN1qn0R3REq-mu7MoPqV+=KWnZv+DQi64PZ7hWf4o1NA@mail.gmail.com>
	<CAOGo0VYavjyWVqyu++Wt6SSV96wGoAYM1pt9WMn-1ayhhTMb=A@mail.gmail.com>
	<CACZkXPzjhi3sW7fNMWkJOL=5ojXGq7bCRAcVDNm2JR-X8M1KuQ@mail.gmail.com>
	<CAOGo0VbZU9O+zyZf5GgqoKnJw4y8JQmjzYLz0Aho8UKtbpk1sQ@mail.gmail.com>
	<519DA0B7.7090304@gmail.com>
Date: Thu, 23 May 2013 08:02:39 +0100
Message-ID: 
 <CAOGo0Vb92QkWKogAogrSS-KqShwi-OJpm+HrmjTV8oQHJS7c8g@mail.gmail.com>
Subject: Re: [parent][all] JaCoCo vs. Cobertura
From: sebb <sebbaz@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On 23 May 2013 05:53, Phil Steitz <phil.steitz@gmail.com> wrote:
> On 5/22/13 5:45 PM, sebb wrote:
>> On 23 May 2013 01:15, Gary Gregory <garydgregory@gmail.com> wrote:
>>> On Wed, May 22, 2013 at 7:43 PM, sebb <sebbaz@gmail.com> wrote:
>>>
>>>> On 22 May 2013 17:52, Gary Gregory <garydgregory@gmail.com> wrote:
>>>>> Hi All:
>>>>>
>>>>> [parent] version 29 replaces Cobertura with Jacoco, the main reasoning
>>>> from
>>>>> the folks over at [math] being that Jacoco is very fast compared to
>>>>> Cobertura. In the case of [math] it's hours vs. minutes.
>>>>>
>>>>> The problem is that Jacoco produces bogus results as I recently emailed
>>>>> about the [io] component. The large portion of the code is reported with
>>>> 0%
>>>>> coverage which is completely wrong. This is apparently a known issue due
>>>> to
>>>>> the Jacoco use of 'probes' to analyze code which is not compatible with
>>>> the
>>>>> use of exceptions.
>>>>>
>>>>> If you get the latest from [io] and edit the POM to enable JaCoC, you can
>>>>> compare both reports in the generated site with 'mvn clean site'.
>>>>>
>>>>> Fast and bogus is not better than slow and right.
>>>>>
>>>>> I propose we switch [parent] back to Cobertura until a better alternative
>>>>> is proposed. [math] can decide if it can live with the fast and bad
>>>> results
>>>>> provided by Jacoco.
>>>> Why not include both as options, so components can choose?
>>>>
>>> Sure, why not, it would be nice to be able to run both for the same report
>>> set to see the differences.
>> As a test I created profiles for JaCoCo and Cobertura.
>> These work fine when activated via the command-line.
>>
>> I had hoped to use a property defined in the component POM to enable
>> the default coverage provider, unfortunately the profiles are resolved
>> before the properties are defined.
>>
>> However file-based activation does work OK - this would require
>> projects to define a dummy file somewhere, for example:
>>
>> src/site/resources/coverage.jacoco
>> or
>> src/site/resources/coverage.cobertura
>>
>> A component can thereby define the appropriate default coverage tool.
>>
>> This can be overridden on the command line, for example:
>>
>> -P!jacoco -Pcobertura
>
> Why not just let projects add a coverage reporting plugin if they
> want it?  I think that is how maven is designed to work :)

That's equivalent to what I was proposing.
The profiles would be optional.

The idea of having it in the parent pom is to reduce the work in
maintaining child poms, and make it simpler to switch between plugins
(or indeed run both or neither).

Common code and all that.

> Phil
>>
>>> Gary
>>>
>>>> I'm currently experimenting with profiles to see if this can be done
>>>> easily.
>>>>
>>>>> Gary
>>>>>
>>>>> --
>>>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>>>> Java Persistence with Hibernate, Second Edition<
>>>> http://www.manning.com/bauer3/>
>>>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>>>> Spring Batch in Action <http://www.manning.com/templier/>
>>>>> Blog: http://garygregory.wordpress.com
>>>>> Home: http://garygregory.com/
>>>>> Tweet! http://twitter.com/GaryGregory
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>>>> For additional commands, e-mail: dev-help@commons.apache.org
>>>>
>>>>
>>>
>>> --
>>> E-Mail: garydgregory@gmail.com | ggregory@apache.org
>>> Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
>>> JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
>>> Spring Batch in Action <http://www.manning.com/templier/>
>>> Blog: http://garygregory.wordpress.com
>>> Home: http://garygregory.com/
>>> Tweet! http://twitter.com/GaryGregory
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org