Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 857B098C0 for ; Fri, 17 May 2013 14:43:01 +0000 (UTC) Received: (qmail 89428 invoked by uid 500); 17 May 2013 14:43:00 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 89175 invoked by uid 500); 17 May 2013 14:42:59 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 89131 invoked by uid 99); 17 May 2013 14:42:57 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 May 2013 14:42:57 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of sebbaz@gmail.com designates 209.85.128.179 as permitted sender) Received: from [209.85.128.179] (HELO mail-ve0-f179.google.com) (209.85.128.179) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 May 2013 14:42:53 +0000 Received: by mail-ve0-f179.google.com with SMTP id oz10so4002875veb.38 for ; Fri, 17 May 2013 07:42:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type:content-transfer-encoding; bh=vufITlMjT3vV7WpWGQdm2iLlBIRpegCuhcjTN+PYzVY=; b=UGZL3IS3VBBO6u796we9RJc4vBEloM68JqWwAFXk9sMiWM0J1kugvY9Gn764/3da5U cKMvzngS3LAy5FT44h1iH3ehmtYSfkZUI+ShKt2i/sUZN9OSaju5aOI9Jm3RmXTplB+l lfPYxyLv45672w8LRgBDlXaKTT7d62zCRvP0V9ErCCCM9Q7MQ+W2b/TurrSb12IaaK10 IE5QUX+u+CYTqQp8XSphjB3IEIBKYupKwo1gykX1NqB9/iM7FmrO0OBjTOgJgXNzMflL ZtwmS5YRvA4mAudhEph8loKC9ikMcl05QfZeDujZhV3LrYm6x6hJusmMtrHlKX3TkazD aAyA== MIME-Version: 1.0 X-Received: by 10.58.90.66 with SMTP id bu2mr30130141veb.29.1368801752317; Fri, 17 May 2013 07:42:32 -0700 (PDT) Received: by 10.59.1.37 with HTTP; Fri, 17 May 2013 07:42:32 -0700 (PDT) In-Reply-To: <51951674.80506@mebigfatguy.com> References: <51951674.80506@mebigfatguy.com> Date: Fri, 17 May 2013 15:42:32 +0100 Message-ID: Subject: Re: [IO] converting streams to buffered versions - rename asBufferedxxxx to buffer?` From: sebb To: Commons Developers List Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On 16 May 2013 18:25, Dave Brosius wrote: > or ByteArrayInput/OutputStream > > > On 05/16/2013 01:13 PM, J=F6rg Schaible wrote: >> >> sebb wrote: >> >>> The issue >>> https://issues.apache.org/jira/browse/IO-330 >>> >>> added 4 methods: >>> public static BufferedXXXX asBufferedXXXX(final XXXX xxxx) >>> where XXXX =3D InputStream, OutputStream, Reader, Writer >>> >>> I just noticed that >>> https://issues.apache.org/jira/browse/IO-233 >>> suggests overloaded methods called buffer instead: >>> >>> public static BufferedXXXX buffer(final XXXX xxxx) >>> >>> This is quite a lot easier to type, so I propose to rename the methods >>> (and link the JIRAs) unless there are objections. >> >> +1 >> >> However, I'd wrap the provided stream/reader/writer only, if it is not >> already a (derived) buffered implementation. That's what the asBufferedXXXX methods already do - they buffer the IO channel if not already buffered. >> Cheers, >> J=F6rg >> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org >> For additional commands, e-mail: dev-help@commons.apache.org >> >> > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org