Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7A1C71065D for ; Sun, 5 May 2013 12:21:39 +0000 (UTC) Received: (qmail 4469 invoked by uid 500); 5 May 2013 12:21:39 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 3607 invoked by uid 500); 5 May 2013 12:21:34 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 3577 invoked by uid 99); 5 May 2013 12:21:33 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 May 2013 12:21:33 +0000 Received: from localhost (HELO mail-we0-f174.google.com) (127.0.0.1) (smtp-auth username britter, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Sun, 05 May 2013 12:21:33 +0000 Received: by mail-we0-f174.google.com with SMTP id z2so2327288wey.19 for ; Sun, 05 May 2013 05:21:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=j2JnQwln7JdpWE8wTGsrmX4k8i8o8QYLVLBqdoYbWsE=; b=WmoMjBJxU8CdG9qtY9eiqHe9bddwPOghe49dZVGlQ2Qqd9YrQsLqmGXa6PNSRkukoH Apzdp6vepxFwZxwLjRjn7FlGgibNZlCHTc0i3U/yXJdomTHNkRaA+Egowy65QEhsnymN ye3nXD0XH8ormWeMedSfjGvlJ6d9Ty5M4n8NfNJJOqvVvFzetdOyDmvJXvkbRYDLHI63 T5+dcY9pm2j3pcMZr41vw8eqAQiOcDcnYHi0aWtiuJftpHwiNj0OsxuMehbvCT9pTVxO 4v9zzKjByVhYf+9zk2CdIqBJIr/SV0KZljfV/jlWhJjnjiaJucObXAwUqe6I0qUB8D86 bpwg== MIME-Version: 1.0 X-Received: by 10.180.160.200 with SMTP id xm8mr4503583wib.23.1367756491534; Sun, 05 May 2013 05:21:31 -0700 (PDT) Received: by 10.194.84.40 with HTTP; Sun, 5 May 2013 05:21:31 -0700 (PDT) In-Reply-To: References: <5CDB2280B9F2934B86B5DD3C70D532A603039C@exmbx05-cdc.nexus.csiro.au> Date: Sun, 5 May 2013 14:21:31 +0200 Message-ID: Subject: Re: [beanutils] Bad performance of MethodUtils#getMatchingAccessibleMethod due to Logger use From: Benedikt Ritter To: Commons Developers List Content-Type: multipart/alternative; boundary=047d7b625020d139d004dbf79f29 --047d7b625020d139d004dbf79f29 Content-Type: text/plain; charset=ISO-8859-1 I have created BEANUTILS-439 [1] for this issue. I'll wait for another few days to give others a chance to create a patch before I fix this myself. Benedikt [1] https://issues.apache.org/jira/browse/BEANUTILS-439 2013/5/2 Benedikt Ritter > Hi Carsten, > > thanks for your report. The usual way to report any kind of > bug/enhancement is to file an issue in Jira [1]. If you attach your > proposal as SVN diff file, we can acknowledge your contribution in the > contributors section of the components website. > > [1] https://issues.apache.org/jira > > > 2013/5/2 > > I'm currently tracking down performance issues in a highly multi-threaded >> application which heavily uses BeanUtils (1.8.3). I identified >> MethodUtils#getMatchingAccessibleMethod as a major problem. Especially its >> call to >> >> >> Log log = LogFactory.getLog(MethodUtils.class); >> >> for each invocation. In my environment, using log4j, this always involves >> a call to HashTable which is synchronised. This causes a lot of waiting >> time in that call in my application. >> >> Please consider using a static logger on class level rather than the new >> logger for each invocation of MethodUtils#getMatchingAccessibleMethod. >> >> Cheers, >> Carsten >> >> > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter --047d7b625020d139d004dbf79f29--