Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 303DF106AA for ; Fri, 3 May 2013 06:40:35 +0000 (UTC) Received: (qmail 55734 invoked by uid 500); 3 May 2013 06:40:34 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 54681 invoked by uid 500); 3 May 2013 06:40:30 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 54591 invoked by uid 99); 3 May 2013 06:40:28 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2013 06:40:28 +0000 Received: from localhost (HELO mail-wg0-f54.google.com) (127.0.0.1) (smtp-auth username britter, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 May 2013 06:40:28 +0000 Received: by mail-wg0-f54.google.com with SMTP id x12so1250782wgg.21 for ; Thu, 02 May 2013 23:40:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=GShwTCKq5naXmIoI7uYc9i8VXgS8soeiTAZKkHjaGjo=; b=NrAKlx3Bx7jbwh/wD9f0LJsl263ry/u98PCvgDdxTapLb5RE/8uhDD8PuU4z+OQ3Sg UtTn3yqHFPNHt7fG1UCqzL77mqaRpod3fXciAUITlDiReTxtF/XljEcXaD7Dx9hzrDzU AzZCAXb0qv8kGvqQyXm5vaA0eUisU3OYh3NslxQKVNcmvZfLzpZHkBh0UT8d/9J6BwuT 9RhcsC+Ym1xJU/ooilTCgOY4hRHEmgmvPSFHgrnN/oBGvIOXAPFdWO+w9T2tnRy2xfle AzJGXh27vwpXQCCKCoHBY+AhVwJ8nwS/K6znXfvM+CUr4TrL9haUUdrPndd+rpr7vgsV K7wA== MIME-Version: 1.0 X-Received: by 10.194.78.137 with SMTP id b9mr11875500wjx.10.1367563226572; Thu, 02 May 2013 23:40:26 -0700 (PDT) Received: by 10.194.84.40 with HTTP; Thu, 2 May 2013 23:40:26 -0700 (PDT) In-Reply-To: <20130503063759.062CD2388847@eris.apache.org> References: <20130503063759.062CD2388847@eris.apache.org> Date: Fri, 3 May 2013 08:40:26 +0200 Message-ID: Subject: Re: svn commit: r1478655 - /commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java From: Benedikt Ritter To: Commons Developers List Content-Type: multipart/alternative; boundary=047d7bd91a6253ef4504dbcaa068 --047d7bd91a6253ef4504dbcaa068 Content-Type: text/plain; charset=ISO-8859-1 The format field in Lexer is now only used by CSVLexer1 in the test directory. It may therefore be removed. I wonder if the isXXX methods really belong to CSVFormat. WDYT? Benedikt 2013/5/3 > Author: britter > Date: Fri May 3 06:37:58 2013 > New Revision: 1478655 > > URL: http://svn.apache.org/r1478655 > Log: > Use isDelimiter method instead of != check. > > Modified: > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > > Modified: > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > URL: > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java?rev=1478655&r1=1478654&r2=1478655&view=diff > > ============================================================================== > --- > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > (original) > +++ > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/Lexer.java > Fri May 3 06:37:58 2013 > @@ -146,7 +146,7 @@ abstract class Lexer { > * @return true if the given char is a whitespace character > */ > boolean isWhitespace(final int c) { > - return c != format.getDelimiter() && > Character.isWhitespace((char) c); > + return !isDelimiter(c) && Character.isWhitespace((char) c); > } > > /** > > > -- http://people.apache.org/~britter/ http://www.systemoutprintln.de/ http://twitter.com/BenediktRitter http://github.com/britter --047d7bd91a6253ef4504dbcaa068--