commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: [chain] improving current registry and configuration APIs
Date Tue, 28 May 2013 08:50:50 GMT
Hi Bene!
thanks a lot in advance! new fresh energies are required at all
levels, from giving feedbacks 'till leg-work! :)
welcome aboard!
Alles Gute!
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Tue, May 28, 2013 at 8:43 AM, Benedikt Ritter <britter@apache.org> wrote:
> Hi Simo,
>
>
> 2013/5/27 Simone Tripodi <simonetripodi@apache.org>
>
>> Hi all Chain-ers,
>>
>> I had yet another small review yesterday[1] at current Configuration
>> APIs and I am not satisfied yet for the following reasons:
>>
>>  * org.apache.commons.chain2.CatalogFactory should maybe moved from
>> `core` module to the `api` module;
>>
>>  * org.apache.commons.chain2.CatalogFactory is an abstract class, but
>> the static `getInstance()` method relies to a specific concrete
>> implementation;
>>
>>  * org.apache.commons.chain2.CatalogFactory mixes the concept of
>> Factory and Registry - more I read that codebase, more I get confused,
>> IMHO it should be split in two different classes with two different
>> roles;
>>
>>  * after introducing the configuration facade APIs,
>> org.apache.commons.chain2.CatalogFactory#checkForValidConfigurationModule()
>> lost its purpose - I suggest to drop it and make the CatalogFactory
>> completely un-aware of the existence of the configuration.
>>
>>  * the most confusing part is still, IMHO, how the config APIs work:
>> the org.apache.commons.chain2.config.ConfigParser#parse(URL) method
>> parses a textual format of Chain representation and populates
>> org.apache.commons.chain2.CatalogFactory retrieving the static
>> singleton instance and populate it... IMHO, it would be easier if the
>> `parse(URL)` method just returns a CatalogFactory instance.
>>
>> This is just to start, I think much more will come when I'll have
>> another look at current codebase.
>>
>> Now, the question is: is there any committer(s)/contributor(s) that
>> can/wishes to help on the Chain component? Due to my reduced spare
>> time slot, I cannot handle it all alone and it would be good, after
>> more than one year of work, speaking about an RC :)
>>
>
> I didn't have the time to take a look at the code base, but I'm interested
> in getting involved. I will probably have a few cycles the next days. After
> I have digged into the code I'll comment on the topics you mentioned.
>
> This is going to be fun! :)
>
> Benedikt
>
>
>>
>> Many thanks in advance, all the best!
>> -Simo
>>
>> [1] http://svn.apache.org/viewvc?view=revision&revision=1486478
>>
>> http://people.apache.org/~simonetripodi/
>> http://simonetripodi.livejournal.com/
>> http://twitter.com/simonetripodi
>> http://www.99soft.org/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
>
>
> --
> http://people.apache.org/~britter/
> http://www.systemoutprintln.de/
> http://twitter.com/BenediktRitter
> http://github.com/britter

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message