commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Luc Maisonobe <Luc.Maison...@free.fr>
Subject Re: [ALL] Cobertura and Parent POM
Date Wed, 08 May 2013 16:56:08 GMT
Hi all,

Le 05/04/2013 22:49, Gary Gregory a écrit :
> On Fri, Apr 5, 2013 at 4:30 PM, Phil Steitz <phil.steitz@gmail.com> wrote:
> 
>> On 4/4/13 1:03 PM, sebb wrote:
>>> CP 28 moved Cobertura to a profile called "reporting".
>>>
>>> The profile was activated by default, but could be disabled by using
>>>
>>> -DskipReports=true
>>> or
>>> -P!reporting
>>>
>>> IIRC, the idea was to move expensive (long-running) reports to a profile
>>> that could be disabled if necessary.
>>>
>>> However Cobertura causes problems with some projects, and the project
>> seems
>>> to be unmaintained, so perhaps it would be sensible to disable Cobertura
>> by
>>> default.
>>> In which case the profile and property should be renamed to reflect the
>>> fact that it only affects Cobertura.
>>>
>>> Possibly even drop Cobertura entirely from the parent POM.
>> +1
>>>
>>> However, I think it is important that some code coverage tool is used.
>>
>> I would say let components decide whether they want to a) include
>> something b) use Sonar c) nothing.
>>
> 
> All components 'should' provide coverage reports IMO, so configure one in
> parent. If you really do not want one, then you have to 'configure by
> exception' and remove it.
> 
> I think we are to the point now where we want to say goodbye to Cobertura
> and hello to Jacoco.

I'm reviving this thread one month later.

I have committed the necessary changes in commons-parent pom. I tried
this on [math] and it works great! No changes required in the components
pom (except of course updating parent pom to 29-SNAPSHOT and
making sure it is lacally installed).

The reports are perfectly inserted in the reporting section when we run
"mvn site".

The most important facts are:

 - it is *much* faster (the two most time-consuming tests in [math] are
   still commented out, but even in this configuration, running "mvn
   site" took 4 hours on my machine before the changes (it took 9 hours
   with the two tests activated), now it takes 9 minutes!

 - the bunch of weird errors due to wrong parsing of some litteral
   constants (due to cobertura using an obsolete version of javacc)
   are now gone

Could someone check how it works on other components?

Do you think we could release version 29 of commons parent pom?

Best regards,
Luc

> 
> Gary
> 
> 
>>
>> Phil
>>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
>> For additional commands, e-mail: dev-help@commons.apache.org
>>
>>
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message