Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of garydgregory@gmail.com
 designates 209.85.214.53 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOGo0VaWcrZdVfGVxnWnRvhDL=CHtUo9EXkUsiCuFY5insWD_A@mail.gmail.com>
References: 
 <CAOGo0VaWcrZdVfGVxnWnRvhDL=CHtUo9EXkUsiCuFY5insWD_A@mail.gmail.com>
Date: Mon, 22 Apr 2013 13:10:48 -0400
Message-ID: 
 <CACZkXPx0Fu8Lb2rg=tAPOrYy+ER1u9MFVvtbQyXd0SzcT5udDw@mail.gmail.com>
Subject: Re: [IO] CharSequenceInputStream - strange code
From: Gary Gregory <garydgregory@gmail.com>
To: Commons Developers List <dev@commons.apache.org>
Content-Type: multipart/alternative; boundary=bcaec52997c16dacd504daf6262e

--bcaec52997c16dacd504daf6262e
Content-Type: text/plain; charset=UTF-8

I looked at this a couple of month ago and found it equally confusing.

Gary


On Mon, Apr 22, 2013 at 12:14 PM, sebb <sebbaz@gmail.com> wrote:

> I'm trying to fix IO-356, and having problems.
>
> I think this is because the code is a bit confused.
>
> The read() method reads bytes from the encoded byte buffer.
>
> However skip(int) skips the underlying CharBuf, and available() checks the
> CharBuf
>
> I would expect read() and skip(1) to have the same effect (except possibly
> at EOF).
> However that is not the case currently.
>
> Also I would expect available() to relate to the number of characters
> available for read().
>
> The class extends InputStream, and I would expect all the
> overridden/implemented methods to relate to the InputStream, not the source
> Charset.
>
> Or am I missing something here?
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
Java Persistence with Hibernate, Second Edition<http://www.manning.com/bauer3/>
JUnit in Action, Second Edition <http://www.manning.com/tahchiev/>
Spring Batch in Action <http://www.manning.com/templier/>
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

--bcaec52997c16dacd504daf6262e--