commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [CSV-96] Are we satisfied with the implemented solution?
Date Mon, 08 Apr 2013 19:36:57 GMT
2013/4/8 Emmanuel Bourg <ebourg@apache.org>

> Le 08/04/2013 20:15, Benedikt Ritter a écrit :
>
> > One thing I'd like to do is convert the ArrayOutOfBoundsExpcetion that
> may
> > be thrown from get(String) into something that is a bit more expressive
> in
> > the context of CSVRecords. How do you feel about this? There should be no
> > impact on performance.
>
> The performance impact can't be guessed, it has to be measured. I've
> been bitten by many non intuitive performance degradations when I was
> experimenting with trivial changes in the CSVParser, so I'm very careful
> on this topic now.
>

Hey Emmanuel,

thanks for catching up on this. I have commited this in r1465738 just to
see your comment now. I'll do some tests to be sure that performance hasn't
been affected.

Benedikt


>
> Emmanuel Bourg
>
>
>


-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message