Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F4054F468 for ; Sun, 24 Mar 2013 14:15:20 +0000 (UTC) Received: (qmail 70239 invoked by uid 500); 24 Mar 2013 14:15:20 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 70114 invoked by uid 500); 24 Mar 2013 14:15:20 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 70100 invoked by uid 99); 24 Mar 2013 14:15:20 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Mar 2013 14:15:20 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS,URIBL_DBL_REDIR X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of garydgregory@gmail.com designates 209.85.214.54 as permitted sender) Received: from [209.85.214.54] (HELO mail-bk0-f54.google.com) (209.85.214.54) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 24 Mar 2013 14:15:16 +0000 Received: by mail-bk0-f54.google.com with SMTP id q16so101052bkw.27 for ; Sun, 24 Mar 2013 07:14:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:x-received:in-reply-to:references:date:message-id :subject:from:to:content-type; bh=G9kU5ANc2vkGM8bFumfeIrmKW8qR5O3dBc6OuGKgL44=; b=OyGIvv94Etvuh0FUcfLW/JKW1yLOt5X8dopm0j9C1wivvgVwD3dQcag2ndWePyL+tC JlXwGEz12qiUlJ1ZxdDIjEBBkHFNN6SZyxlHmxXb6+KXvnfbxrQ18l57VC99XVKnLKy1 B4+fCt5rNkuPIEBiwGO/1Q9kbQ8W1S1SaMY/br5nymtql5dMkRowfOwTT99D0XdAG9xY gltTZN2cBDLpTnGPpdyKmDguftR8rCPFB57jHGXzTp0l4a041nC7F5bvCCSPmgZD7L46 WrFNIUZXVnlhxDn1QrELWz4nkc7xRagb2uxRg7ikUos0FpA2F34o0sb0q+dfn7OvWp0n aWTA== MIME-Version: 1.0 X-Received: by 10.204.163.142 with SMTP id a14mr4043420bky.9.1364134494959; Sun, 24 Mar 2013 07:14:54 -0700 (PDT) Received: by 10.204.32.83 with HTTP; Sun, 24 Mar 2013 07:14:54 -0700 (PDT) In-Reply-To: References: <20130324020212.2A95023888FD@eris.apache.org> Date: Sun, 24 Mar 2013 10:14:54 -0400 Message-ID: Subject: Re: svn commit: r1460254 - in /commons/proper/csv/trunk/src: main/java/org/apache/commons/csv/CSVFormat.java test/java/org/apache/commons/csv/CSVFormatBuilderTest.java From: Gary Gregory To: Commons Developers List Content-Type: multipart/alternative; boundary=bcaec52d55afffb27f04d8ac4ffb X-Virus-Checked: Checked by ClamAV on apache.org --bcaec52d55afffb27f04d8ac4ffb Content-Type: text/plain; charset=UTF-8 On Sun, Mar 24, 2013 at 9:06 AM, Benedikt Ritter wrote: > 2013/3/24 > > > Author: ggregory > > Date: Sun Mar 24 02:02:11 2013 > > New Revision: 1460254 > > > > URL: http://svn.apache.org/r1460254 > > Log: > > Add a toBuilder method to do: > > CSVFormat format = CSVFormat.EXCEL.toBuilder().withHeader("Col1", "Col2", > > "Col3").build(); > > Instead of: > > CSVFormat format = > > CSVFormat.newBuilder(CSVFormat.EXCEL).withHeader("Col1", "Col2", > > "Col3").build(); > > > > Good idea Gary! I like this. > Thank you BenediKt ;) Gary > > > > > Modified: > > > > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java > > > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatBuilderTest.java > > > > Modified: > > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java > > URL: > > > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java?rev=1460254&r1=1460253&r2=1460254&view=diff > > > > > ============================================================================== > > --- > > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java > > (original) > > +++ > > > commons/proper/csv/trunk/src/main/java/org/apache/commons/csv/CSVFormat.java > > Sun Mar 24 02:02:11 2013 > > @@ -471,6 +471,15 @@ public class CSVFormat implements Serial > > } > > > > /** > > + * Creates a builder based on this format. > > + * > > + * @return a new builder > > + */ > > + public CSVFormatBuilder toBuilder() { > > + return new CSVFormatBuilder(this); > > + } > > + > > + /** > > * Builds CSVFormat objects. > > */ > > public static class CSVFormatBuilder { > > > > Modified: > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatBuilderTest.java > > URL: > > > http://svn.apache.org/viewvc/commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatBuilderTest.java?rev=1460254&r1=1460253&r2=1460254&view=diff > > > > > ============================================================================== > > --- > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatBuilderTest.java > > (original) > > +++ > > > commons/proper/csv/trunk/src/test/java/org/apache/commons/csv/CSVFormatBuilderTest.java > > Sun Mar 24 02:02:11 2013 > > @@ -59,6 +59,8 @@ public class CSVFormatBuilderTest { > > public void testCopiedFormatWithChanges() { > > final CSVFormat newFormat = > > CSVFormat.newBuilder(RFC4180).withDelimiter('!').build(); > > assertTrue(newFormat.getDelimiter() != RFC4180.getDelimiter()); > > + final CSVFormat newFormat2 = > > RFC4180.toBuilder().withDelimiter('!').build(); > > + assertTrue(newFormat2.getDelimiter() != RFC4180.getDelimiter()); > > } > > > > @Test > > > > > > > > > -- > http://people.apache.org/~britter/ > http://www.systemoutprintln.de/ > http://twitter.com/BenediktRitter > http://github.com/britter > -- E-Mail: garydgregory@gmail.com | ggregory@apache.org JUnit in Action, 2nd Ed: http://bit.ly/ECvg0 Spring Batch in Action: http://bit.ly/bqpbCK Blog: http://garygregory.wordpress.com Home: http://garygregory.com/ Tweet! http://twitter.com/GaryGregory --bcaec52d55afffb27f04d8ac4ffb--