Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 01956C2CB for ; Tue, 19 Mar 2013 11:06:33 +0000 (UTC) Received: (qmail 24216 invoked by uid 500); 19 Mar 2013 11:06:31 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 23969 invoked by uid 500); 19 Mar 2013 11:06:31 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 23930 invoked by uid 99); 19 Mar 2013 11:06:30 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Mar 2013 11:06:30 +0000 Received: from localhost (HELO [192.168.23.9]) (127.0.0.1) (smtp-auth username markt, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Tue, 19 Mar 2013 11:06:29 +0000 Message-ID: <514846B0.1030708@apache.org> Date: Tue, 19 Mar 2013 11:06:24 +0000 From: Mark Thomas User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: Commons Developers List Subject: Re: svn commit: r1458220 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java References: <20130319105617.7520C23888CD@eris.apache.org> In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 19/03/2013 11:01, Simone Tripodi wrote: > cool, thanks! No problem. Thanks for all your recent work on FileUpload (and to you sebb). It is much appreciated. Mark > > http://people.apache.org/~simonetripodi/ > http://simonetripodi.livejournal.com/ > http://twitter.com/simonetripodi > http://www.99soft.org/ > > > On Tue, Mar 19, 2013 at 11:56 AM, wrote: >> Author: markt >> Date: Tue Mar 19 10:56:17 2013 >> New Revision: 1458220 >> >> URL: http://svn.apache.org/r1458220 >> Log: >> There needs to be the same number of place-holders as there are replacements. >> Fixes an issue introduced in r1453239. >> Identified by FindBugs running against the Tomcat code base (which has a package renamed copy of FileUpload). >> >> Modified: >> commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java >> >> Modified: commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java >> URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java?rev=1458220&r1=1458219&r2=1458220&view=diff >> ============================================================================== >> --- commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java (original) >> +++ commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/FileUploadBase.java Tue Mar 19 10:56:17 2013 >> @@ -348,7 +348,7 @@ public abstract class FileUploadBase { >> } catch (FileUploadIOException e) { >> throw (FileUploadException) e.getCause(); >> } catch (IOException e) { >> - throw new IOFileUploadException(format("Processing of %s request failed. ", >> + throw new IOFileUploadException(format("Processing of %s request failed. %s", >> MULTIPART_FORM_DATA, e.getMessage()), e); >> } >> final FileItemHeaders fih = item.getHeaders(); >> >> > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org > For additional commands, e-mail: dev-help@commons.apache.org > --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org