Return-Path: X-Original-To: apmail-commons-dev-archive@www.apache.org Delivered-To: apmail-commons-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 889B2E3BC for ; Mon, 18 Mar 2013 19:57:29 +0000 (UTC) Received: (qmail 18327 invoked by uid 500); 18 Mar 2013 19:57:29 -0000 Delivered-To: apmail-commons-dev-archive@commons.apache.org Received: (qmail 18241 invoked by uid 500); 18 Mar 2013 19:57:29 -0000 Mailing-List: contact dev-help@commons.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: "Commons Developers List" Delivered-To: mailing list dev@commons.apache.org Received: (qmail 18233 invoked by uid 99); 18 Mar 2013 19:57:29 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Mar 2013 19:57:29 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of thomas.neidhart@gmail.com designates 74.125.82.48 as permitted sender) Received: from [74.125.82.48] (HELO mail-wg0-f48.google.com) (74.125.82.48) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 18 Mar 2013 19:57:21 +0000 Received: by mail-wg0-f48.google.com with SMTP id 16so5190930wgi.15 for ; Mon, 18 Mar 2013 12:57:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; bh=xqtZDF2JoLUZgt9jcKwh2JJEyFez/trwKsE44uglHMQ=; b=0c+3YLL27rGwqMMYa31z2zXlpgeKblc1MuY+nXY+y6JyTOv9LXkTJQbfZgBhTy5ZCt 2rZFkP3B9k4it1D4GCb0RIPVdUa/s2yATi7E6N1NrffHra+zlJFS9DvCjSu4Ba9U7tW6 SQ1yfauh0lXcs4OlWgsNEF4F4kemindjBDBbeagRxs2jucx3ek0Z6z3CAhZ/JeMcIPmv W4zOi95j/Io+Vci0uLH1OfO8Tl7p9P9mQUdzK6I5N3Qz1jvOvj1BIHsXCXkvDS94dIwm lZaLa0bo0yHV+dGiSwLnbVc70H+G2jDS0LB7ModoxGE26czRMmt6AuHogUtj4ApHH2Gs Nl6Q== X-Received: by 10.194.59.100 with SMTP id y4mr27717705wjq.51.1363636621536; Mon, 18 Mar 2013 12:57:01 -0700 (PDT) Received: from [192.168.1.3] (ip-81-11-251-63.dsl.scarlet.be. [81.11.251.63]) by mx.google.com with ESMTPS id bj9sm2760460wib.4.2013.03.18.12.56.59 (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 18 Mar 2013 12:57:00 -0700 (PDT) Message-ID: <5147718A.3050201@gmail.com> Date: Mon, 18 Mar 2013 20:56:58 +0100 From: Thomas Neidhart User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: Commons Developers List Subject: Re: svn commit: r1457869 - /commons/proper/collections/trunk/src/test/java/org/apache/commons/collections/CollectionUtilsTest.java References: <20130318171109.5115123888FE@eris.apache.org> In-Reply-To: X-Enigmail-Version: 1.5.1 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Virus-Checked: Checked by ClamAV on apache.org On 03/18/2013 08:44 PM, Simone Tripodi wrote: >> >> Are you sure, that we don't have a checkstyle rule for too smart code? >> >> ;-) > > lol, that violates the `Avoid inline conditionals.` rule! :D checkstyle is just a tool, not our master! Disable the rules that do not make sense, just my 2c Thomas --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org For additional commands, e-mail: dev-help@commons.apache.org