Mailing-List: contact dev-help@commons.apache.org; run by ezmlm
Precedence: bulk
Reply-To: "Commons Developers List" <dev@commons.apache.org>
Received-SPF: pass (nike.apache.org: domain of thomas.neidhart@gmail.com
 designates 74.125.82.179 as permitted sender)
Message-ID: <513CEA37.7090108@gmail.com>
Date: Sun, 10 Mar 2013 21:16:55 +0100
From: Thomas Neidhart <thomas.neidhart@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux i686;
 rv:17.0) Gecko/20130221 Thunderbird/17.0.3
MIME-Version: 1.0
To: Commons Developers List <dev@commons.apache.org>
Subject: Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1
References: 
 <CAAqLGLPFGM6q552WZoB6++-6q1WpuQH+7UiUREZ_s1LMP7FHNQ@mail.gmail.com>
 <513B3E58.4020008@gmail.com>
 <CAAqLGLM4SVVKCGX18Qp=CFA4DZDyTBvcLG0URLx5zmLyp8sAnw@mail.gmail.com>
 <513B47D9.2080204@gmail.com>
 <CAAqLGLP8LTn_Ys406OsatM7Ax_y3BLT+o1SNXV3QQpJ5_HzSfQ@mail.gmail.com>
 <513CBC2C.9060106@gmail.com>
 <CAAqLGLO6NZE4F8TQGHUKs8wtpNGKPji6vC6G54B8RBYGRT65-w@mail.gmail.com>
In-Reply-To: 
 <CAAqLGLO6NZE4F8TQGHUKs8wtpNGKPji6vC6G54B8RBYGRT65-w@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit

On 03/10/2013 08:09 PM, Simone Tripodi wrote:
> Hi Thomas,
> 
> thanks a lot for your help, very appreciated! :)
> 
>> Critical
>>
>>  * FILEUPLOAD-212: after looking more carefully into it I think it is
>>    invalid, see the attached test
>>
> 
> +1 I'd close it as `not a problem`
> 
>>  * FILEUPLOAD-193: as stated in the comments already, this was most
>>    likely due to some non-supported filenames in a windows environment
>>    can be resolved as Invalid I guess
>>
> 
> yeah as above, it is a specific environment problem
> 
>> Major
>>
>>  * FILEUPLOAD-205: I think we should fix this, I outlined a possible
>>    fix in the comments.
>>
> 
> looks like you already have an idea how to handle it - do you feel
> comfortable on checkin-in the fix?
> 
>>  * FILEUPLOAD-199: we could copy the MimeUtility class (under CDDL
>>    license) and decode the header values with it, similar as we encode
>>    them in commons-email.
>>
> 
> +1
> 
>>  * FILEUPLOAD-206: supporting content encoding for form-data would be
>>    really helpful I guess
>>
>> additionally, I resolved some more issues as duplicates of others, and
>> provided some comments on others which I tried to reproduce but failed.
>>
> 
> I haven't checked all of them - did you add 1.3 in the `fix version` field?

Issues that are not a problem or invalid should not have a fix version
imho, for duplicates I put the version where this has been fixed.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org