commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jörg Schaible <Joerg.Schai...@scalaris.com>
Subject Re: [fileupload] please help on reviewing FILEUPLOAD-199
Date Wed, 13 Mar 2013 08:30:38 GMT
Hi Simo,

Simone Tripodi wrote:

> Hi Felix!
> 
>> While it looks like the new packages are not exported (which is good), I
>> now get an import on javax.mail.internet. I don't think this makes sense.
>>
> 
> the javax.mail.internet import is at source level only, once the
> shade-plugin has done its job, the import becomes
> o.a.c.fileupload.utils.javax.mail and indeed at OSGi level it must not
> be exported
> 
>> Also the embedded MimeUtility class has refernces to the
>> com.sun.mail.util and javax.activation packages. I am not sure, how this
>> behaves in an OSGi container.
>
> OH I see, that's a huge problem for OSGi purposes - I think I have to
> find a better solution in order to have it fixed....

Why do we have to shade here anything at all? fileupload is meant to run in 
a JEE environment and javax.mail is then provided. What is now different 
with java.xmail compared to the  javax.portlet dependency?

- Jörg


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message