commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1460863 - /commons/proper/ognl/trunk/src/main/java/org/apache/commons/ognl/EvaluationPool.java
Date Mon, 25 Mar 2013 20:27:10 GMT
On 25 March 2013 20:18, Emmanuel Bourg <ebourg@apache.org> wrote:
> Le 25/03/2013 21:11, sebb a écrit :
>
>> -1
>>
>> If this is part of the public API, it will break compatibility.
>> The deprecated ctor does no harm, so please revert.
>
> But it hasn't been released yet, right? It's still time to clean up the API.

OK, in that case, my bad, I withdraw the -1.

To reduce compatibility issues later may I suggest:
- all mutable fields should be private
- all arrays should be private (final arrays still have mutable elements).
- prefer immutable classes - don't use setters unless absolutely necessary
- minimise access as far as possible.
- consider dividing the classes into public API and internal implementation
So long as it is clear to users which classes are not intended for
external use (even if public) then thos classes can be rewritten
without worrying about binary compat. If a 3rd party does use the
fobidden API, then they cannot complain if a future release breaks it.

> Emmanuel Bourg
>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message