commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebb <seb...@gmail.com>
Subject Re: svn commit: r1457915 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
Date Mon, 18 Mar 2013 21:30:07 GMT
On 18 March 2013 18:45,  <ggregory@apache.org> wrote:
> Author: ggregory
> Date: Mon Mar 18 18:45:56 2013
> New Revision: 1457915
>
> URL: http://svn.apache.org/r1457915
> Log:
> Fix Javadoc.
>
> Modified:
>     commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
>
> Modified: commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
> URL: http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java?rev=1457915&r1=1457914&r2=1457915&view=diff
> ==============================================================================
> --- commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
(original)
> +++ commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
Mon Mar 18 18:45:56 2013
> @@ -27,6 +27,7 @@ import java.util.List;
>  import java.util.Set;
>
>  import org.apache.commons.collections.CollectionUtils;
> +import org.apache.commons.collections.collection.CompositeCollection;

This can cause "unused import" complaints and is misleading about what
the class actually needs.
I think it's better to qualify the Javadoc.

>  import org.apache.commons.collections.iterators.EmptyIterator;
>  import org.apache.commons.collections.iterators.IteratorChain;
>  import org.apache.commons.collections.list.UnmodifiableList;
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message