commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Matt Benson <gudnabr...@gmail.com>
Subject Re: [fileupload] towards 1.3 release - feedbacks required
Date Tue, 19 Mar 2013 19:46:56 GMT
Yes, you can shade only the classes needed.  Getting rid of code that does
the same thing across multiple Commons components seems a worthwhile use of
time IMO and really shouldn't represent any more work than fixing the
broken classes in [fileupload].  Also, no triage is required to figure out
how to implement this solution, as opposed to the case with fixing buggy
code.

Matt


On Tue, Mar 19, 2013 at 2:30 PM, sebb <sebbaz@gmail.com> wrote:

> -1 if this results in a huge increase in size of the jar.
> If shading can extract only the required classes, that might be OK,
> but it seems like a lot of work when the code already works for valid
> input.
>
> I think the only outstanding problems are the way the decoders handle
> invalid input.
>
>
> On 19 March 2013 19:25, Maurizio Cucchiara <mcucchiara@apache.org> wrote:
> >> Why not depend on [codec] and shade, then?
> > +1
> >
> > Maurizio Cucchiara
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> > For additional commands, e-mail: dev-help@commons.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message