commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: svn commit: r1457915 - /commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
Date Mon, 18 Mar 2013 21:51:13 GMT
Hm... I consider this a bug in checkstyle or whatever does the
complaining...

Gary


On Mon, Mar 18, 2013 at 5:30 PM, sebb <sebbaz@gmail.com> wrote:

> On 18 March 2013 18:45,  <ggregory@apache.org> wrote:
> > Author: ggregory
> > Date: Mon Mar 18 18:45:56 2013
> > New Revision: 1457915
> >
> > URL: http://svn.apache.org/r1457915
> > Log:
> > Fix Javadoc.
> >
> > Modified:
> >
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
> >
> > Modified:
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
> > URL:
> http://svn.apache.org/viewvc/commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java?rev=1457915&r1=1457914&r2=1457915&view=diff
> >
> ==============================================================================
> > ---
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
> (original)
> > +++
> commons/proper/collections/trunk/src/main/java/org/apache/commons/collections/set/CompositeSet.java
> Mon Mar 18 18:45:56 2013
> > @@ -27,6 +27,7 @@ import java.util.List;
> >  import java.util.Set;
> >
> >  import org.apache.commons.collections.CollectionUtils;
> > +import org.apache.commons.collections.collection.CompositeCollection;
>
> This can cause "unused import" complaints and is misleading about what
> the class actually needs.
> I think it's better to qualify the Javadoc.
>
> >  import org.apache.commons.collections.iterators.EmptyIterator;
> >  import org.apache.commons.collections.iterators.IteratorChain;
> >  import org.apache.commons.collections.list.UnmodifiableList;
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>
>


-- 
E-Mail: garydgregory@gmail.com | ggregory@apache.org
JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
Blog: http://garygregory.wordpress.com
Home: http://garygregory.com/
Tweet! http://twitter.com/GaryGregory

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message