commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Benedikt Ritter <brit...@apache.org>
Subject Re: [CSV] org.apache.commons.csv.CSVFormat.DEFAULT
Date Wed, 20 Mar 2013 07:54:52 GMT
Hi Gary,


2013/3/20 Gary Gregory <garydgregory@gmail.com>

> Addressing this TODO:
>
>     /**
>      * Standard comma separated format, as for {@link #RFC4180} but
> allowing empty lines.
>      * <ul>
>      * <li>withDelimiter(',')</li>
>      * <li>withQuoteChar('"')</li>
>      * <li>withIgnoreEmptyLines(true)</li>
>      * <li>withLineSeparator(CRLF)</li>
>      * </ul>
>      */
>     public static final CSVFormat DEFAULT = // TODO rename to something
> more meaningful
>             newBuilder()
>             .build();
>
> How about one of:
>
> - RFC4180_WITH_EMPTY_LINES
> - RFC4180_EMPTY_LINES
> - RFC4180_IGNORE_EMPTY_LINES
> - BASIC
> - RFC4180_LENIENT
> - ?
>

I agree, that the name should contain RFC4180, because the format(builder)
is derived from the rfc. I would favor RFC4180_EMPTY_LINES, although it is
pretty long.

Benedikt


>
> Gary
>
> --
> E-Mail: garydgregory@gmail.com | ggregory@apache.org
> JUnit in Action, 2nd Ed: <http://goog_1249600977>http://bit.ly/ECvg0
> Spring Batch in Action: <http://s.apache.org/HOq>http://bit.ly/bqpbCK
> Blog: http://garygregory.wordpress.com
> Home: http://garygregory.com/
> Tweet! http://twitter.com/GaryGregory
>



-- 
http://people.apache.org/~britter/
http://www.systemoutprintln.de/
http://twitter.com/BenediktRitter
http://github.com/britter

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message