commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: svn commit: r1455456 - /commons/proper/fileupload/trunk/src/main/java/org/apache/commons/fileupload/servlet/ServletFileUpload.java
Date Wed, 13 Mar 2013 10:01:57 GMT
Hallo Jörg,

> Follow the RFC.

will do, I am updating FILEUPLOAD-229 then will provide the fix.

Alles Gute!
-Simo

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Wed, Mar 13, 2013 at 10:12 AM, Jörg Schaible
<Joerg.Schaible@scalaris.com> wrote:
> Hi Simo,
>
> Simone Tripodi wrote:
>
>> Hi Felix!
>>
>>>
>>> See RFC-2616 5.1.1 Method.
>>>
>>
>> the paragraph is indeed clear about that:
>>
>>    The Method  token indicates the method to be performed on the
>>    resource identified by the Request-URI. The method is case-sensitive.
>>
>>        Method         = "OPTIONS"                ; Section 9.2
>>                       | "GET"                    ; Section 9.3
>>                       | "HEAD"                   ; Section 9.4
>>                       | "POST"                   ; Section 9.5
>>                       | "PUT"                    ; Section 9.6
>>                       | "DELETE"                 ; Section 9.7
>>                       | "TRACE"                  ; Section 9.8
>>                       | "CONNECT"                ; Section 9.9
>>                       | extension-method
>>        extension-method = token
>>
>>> So IMHO there is no need for equalsIgnoreCase or toLowerCase at all and
>>> "POST".equals(...) should just do it.
>>>
>>
>> I'm by your side, I switch my opinion to having just equals() here.
>>
>> What other people think?
>
> Follow the RFC.
>
> - Jörg
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message