commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simone Tripodi <simonetrip...@apache.org>
Subject Re: svn commit: r1461628 - /commons/proper/ognl/trunk/src/main/assembly/src.xml
Date Wed, 27 Mar 2013 16:50:18 GMT
we just voted a component which -src assembly descriptor[1] uses that one

would you reconsider the -1 to -0?

[1] http://svn.apache.org/repos/asf/commons/proper/fileupload/trunk/src/main/assembly/src.xml

http://people.apache.org/~simonetripodi/
http://simonetripodi.livejournal.com/
http://twitter.com/simonetripodi
http://www.99soft.org/


On Wed, Mar 27, 2013 at 5:40 PM, sebb <sebbaz@gmail.com> wrote:
> On 27 March 2013 14:58,  <simonetripodi@apache.org> wrote:
>> Author: simonetripodi
>> Date: Wed Mar 27 14:58:15 2013
>> New Revision: 1461628
>>
>> URL: http://svn.apache.org/r1461628
>> Log:
>> use the `exclude` logic to create the sources archive, rather than specifying what
has to be included
>
> -1
>
> I think that is not nearly as safe, as it will pick up arbitrary
> additional files and directory trees in the root dir.
>
> The previous method of specifying src/ plus specific top-level files
> was only susceptible to spurious files under src/.
> The new method is still susceptible to such files (very difficult to
> avoid that), but is also susceptible lots of other files.
>
>> Modified:
>>     commons/proper/ognl/trunk/src/main/assembly/src.xml
>>
>> Modified: commons/proper/ognl/trunk/src/main/assembly/src.xml
>> URL: http://svn.apache.org/viewvc/commons/proper/ognl/trunk/src/main/assembly/src.xml?rev=1461628&r1=1461627&r2=1461628&view=diff
>> ==============================================================================
>> --- commons/proper/ognl/trunk/src/main/assembly/src.xml (original)
>> +++ commons/proper/ognl/trunk/src/main/assembly/src.xml Wed Mar 27 14:58:15 2013
>> @@ -26,17 +26,17 @@
>>    <baseDirectory>${project.build.finalName}-src</baseDirectory>
>>    <fileSets>
>>      <fileSet>
>> -      <includes>
>> -        <include>checkstyle.xml</include>
>> -        <include>LICENSE.txt</include>
>> -        <include>NOTICE.txt</include>
>> -        <include>pom.xml</include>
>> -        <include>RELEASE-NOTES.txt</include>
>> -        <include>findbugs-exclude-filter.xml</include>
>> -      </includes>
>> -    </fileSet>
>> -    <fileSet>
>> -      <directory>src</directory>
>> +      <directory>${basedir}</directory>
>> +      <excludes>
>> +        <exclude>**/.classpath</exclude>
>> +        <exclude>**/.project</exclude>
>> +        <exclude>**/.settings/</exclude>
>> +        <exclude>**/doap_*.rdf</exclude>
>> +        <exclude>**/bin/</exclude>
>> +        <exclude>**/.externalToolBuilders/</exclude>
>> +        <exclude>**/${project.build.directory}/</exclude>
>> +        <exclude>**/download*.cgi</exclude>
>> +      </excludes>
>>      </fileSet>
>>    </fileSets>
>>  </assembly>
>>
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message