commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gary Gregory <garydgreg...@gmail.com>
Subject Re: [VOTE] Release of Commons Logging 1.1.2 based on RC2
Date Sat, 16 Mar 2013 17:01:37 GMT
On Mar 16, 2013, at 12:45, Thomas Neidhart <thomas.neidhart@gmail.com> wrote:

> On 03/16/2013 03:21 PM, Gary Gregory wrote:
>> Not a blocker but not pretty:
>>
>> The variable testObjCls may be null at line 199 in LoadTestCase.java
>> (/commons-logging/src/test/java/org/apache/commons/logging)
>>
>> And... wow is that code some weird format!
>
> no question about that ;-), but I don't think the variable can be null
> at line 199. This should be covered by the two catches before, and the
> Assert.fail (which eclipse can not detect I guess).

Right! Good catch.

G
>
> Thomas
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
> For additional commands, e-mail: dev-help@commons.apache.org
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message