commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [VOTE] release Apache Commons-FileUpload 1.3 based on RC1
Date Sun, 10 Mar 2013 20:16:55 GMT
On 03/10/2013 08:09 PM, Simone Tripodi wrote:
> Hi Thomas,
> 
> thanks a lot for your help, very appreciated! :)
> 
>> Critical
>>
>>  * FILEUPLOAD-212: after looking more carefully into it I think it is
>>    invalid, see the attached test
>>
> 
> +1 I'd close it as `not a problem`
> 
>>  * FILEUPLOAD-193: as stated in the comments already, this was most
>>    likely due to some non-supported filenames in a windows environment
>>    can be resolved as Invalid I guess
>>
> 
> yeah as above, it is a specific environment problem
> 
>> Major
>>
>>  * FILEUPLOAD-205: I think we should fix this, I outlined a possible
>>    fix in the comments.
>>
> 
> looks like you already have an idea how to handle it - do you feel
> comfortable on checkin-in the fix?
> 
>>  * FILEUPLOAD-199: we could copy the MimeUtility class (under CDDL
>>    license) and decode the header values with it, similar as we encode
>>    them in commons-email.
>>
> 
> +1
> 
>>  * FILEUPLOAD-206: supporting content encoding for form-data would be
>>    really helpful I guess
>>
>> additionally, I resolved some more issues as duplicates of others, and
>> provided some comments on others which I tried to reproduce but failed.
>>
> 
> I haven't checked all of them - did you add 1.3 in the `fix version` field?

Issues that are not a problem or invalid should not have a fix version
imho, for duplicates I put the version where this has been fixed.

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message