commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Thomas Neidhart <thomas.neidh...@gmail.com>
Subject Re: [math] releasing 3.2?
Date Sun, 10 Mar 2013 16:44:32 GMT
On 03/10/2013 05:35 PM, Luc Maisonobe wrote:
> Le 10/03/2013 15:28, Thomas Neidhart a écrit :
>> On 03/04/2013 01:24 PM, Luc Maisonobe wrote:
>>> Hi all,
>>>
>>> I would like to release version 3.2 of [math] soon.
>>> Any thoughts about it?
>>
>> There are 3 Clirr errors:
>>
>> Error   Return type of method 'public int log10()' has been changed to
>> org.apache.commons.math3.dfp.Dfp
> 
> I know about this one, it was introduced with r1449529. I have explained
> it here: <http://markmail.org/message/2ytqu4qmtkkp5v4z>.
> 
> I would in fact consider this change is merely fixing a bug: the log10
> function returned an int when all other mathematical functions properly
> returned a Dfp. The change was two-fold: the log10 method returning an
> int was renamed intLog10, and a proper log10 method was added.
> 
> I really don't think anybody will be affected by this change, as the
> class itself is probably very seldom used, and most importantly because
> despite this weird return type, nobody noticed it and complained about it.
> 
> So I would consider this incompatible change should be accepted, even in
> a minor release.

Ok I understand, I just read the description for 3.2 in the
changes-report and it states:

This is a minor release: It combines bug fixes and new features. Changes
to existing features were made in a backwards-compatible way such as to
allow drop-in replacement of the v3.1[.1] JAR file.

So I guess we will have to update this and mention it in the release-notes.

btw. the Dfp.log10k also returns an int and not a Dfp as the other
methods, is this intended?

Thomas

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message