commons-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Thomas <ma...@apache.org>
Subject Re: svn commit: r1452037 - /commons/proper/beanutils/trunk/src/test/java/org/apache/commons/beanutils/bugs/Jira422TestCase.java
Date Thu, 07 Mar 2013 23:54:45 GMT
On 07/03/2013 23:39, Niall Pemberton wrote:
> On Sun, Mar 3, 2013 at 3:32 PM, sebb <sebbaz@gmail.com> wrote:
>> On 3 March 2013 13:25,  <britter@apache.org> wrote:
>>> Author: britter
>>> Date: Sun Mar  3 13:25:24 2013
>>> New Revision: 1452037
>>>
>>> URL: http://svn.apache.org/r1452037
>>> Log:
>>> Add JavaDoc and SVN Keywords
>>
>> -1
>>
>> Please don't use $Date$ - it is rendered using the client Locale, and
>> so causes problems matching SVN tags against source archives.

<snip/>

> It is also an
> invalid veto IMO because this is purely documentation AND it is only a
> question of style.

I disagree. Sebb's point regarding the locale issues is a valid one.
Something that makes it significantly harder to verify that a source
tarball agrees with an SVN tag is a major issue when it comes to voting
on releases.

One of the primary responsibilities of a PMC member when voting on a
release is verifying what is being voted on against the tag. Different
client locales and $Date$ combine to make every single source file
different from the tag requiring a manual check of the diff of every
file to do the verification check properly. Even with good diff tooling
the verification process is a lot slower and can't be automated.

Mark

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org


Mime
View raw message